fix: Fix issue with uncaught exceptions from timers. #215
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The timer execution adding a promise handler but not correctly handling exceptions and being added to process unhandled exceptions even when the promise.all was also catching the error. # Please enter the commit message for your changes. Lines starting
Member
|
(removing myself from review, i have 7 launches in the next 2 weeks and am not familiar with amagaki's codebase enough to provide quality guidance here.) |
Member
|
@Zoramite I forget how this was originally set up and used (IIRC you may have been the original author!) so I won't be able to provide too much deep thought either here but if it works for you it works for me, so LGTM. |
jeremydw
approved these changes
Mar 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The timer execution was adding a promise
.thenhandler but not handling exceptions.This caused the error to be added to processes' unhandled exceptions even when the promise.all was also catching the error.
This change wraps the timer stopping and the triggering of the plugin hook into an async function. The
Promise.allcan correctly correlate the hooks while still getting accurate time execution.