scipy 1.17.0 incompatible with main branch #60
Description
Installing jim after cloning the repo with pip install -e . results into installing scipy 1.17.0. But it turns out this version is incompatible with jim, and breaks for instance (perhaps also at other locations) in the following simple test
python -c "from jimgw.core.single_event.detector import get_H1, get_L1, get_V1"This gives the following error:
Traceback (most recent call last):
File "/Users/Woute029/Documents/Code/projects/03_jim_multibanding/.venv/lib/python3.11/site-packages/gwpy/signal/window.py", line 30, in <module>
from scipy.signal.windows._windows import _win_equiv as WINDOWS
ImportError: cannot import name '_win_equiv' from 'scipy.signal.windows._windows' (/Users/Woute029/Documents/Code/projects/03_jim_multibanding/.venv/lib/python3.11/site-packages/scipy/signal/windows/_windows.py)
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "<string>", line 1, in <module>
File "/Users/Woute029/Documents/Code/projects/03_jim_multibanding/jim/src/jimgw/core/single_event/detector.py", line 19, in <module>
from jimgw.core.single_event.data import Data, PowerSpectrum
File "/Users/Woute029/Documents/Code/projects/03_jim_multibanding/jim/src/jimgw/core/single_event/data.py", line 8, in <module>
from gwpy.timeseries import TimeSeries
File "/Users/Woute029/Documents/Code/projects/03_jim_multibanding/.venv/lib/python3.11/site-packages/gwpy/timeseries/__init__.py", line 23, in <module>
from .timeseries import (TimeSeries, TimeSeriesDict, TimeSeriesList)
File "/Users/Woute029/Documents/Code/projects/03_jim_multibanding/.venv/lib/python3.11/site-packages/gwpy/timeseries/timeseries.py", line 32, in <module>
from ..signal import (filter_design, qtransform, spectral)
File "/Users/Woute029/Documents/Code/projects/03_jim_multibanding/.venv/lib/python3.11/site-packages/gwpy/signal/filter_design.py", line 34, in <module>
from .window import (get_window, planck)
File "/Users/Woute029/Documents/Code/projects/03_jim_multibanding/.venv/lib/python3.11/site-packages/gwpy/signal/window.py", line 32, in <module>
from scipy.signal.windows.windows import _win_equiv as WINDOWS
ImportError: cannot import name '_win_equiv' from 'scipy.signal.windows.windows' (/Users/Woute029/Documents/Code/projects/03_jim_multibanding/.venv/lib/python3.11/site-packages/scipy/signal/windows/windows.py)Note: using e.g. uv sync seems to give a different scipy version and does not result in this bug.
We should either limit scipy to be below 0.17.0 or figure out a general solution.