Thanks to visit codestin.com
Credit goes to Github.com

Skip to content

[linkify] Enabled config for a rule persists after it is deleted #31

@ahal

Description

@ahal

If you enable a rule in a room, then delete that rule, it will still exist in the key store for that room. This is mostly harmless other than storing unnecessary data as the match algorithm iterates over only the rules that exist. But would be good to clean these up to avoid confusion (especially if we add a command to list enabled rules).

One consideration is what to do when deleting a rule that is enabled in other rooms? Should we:

  1. Delete it anyway and automatically remove the enabled configs?
  2. Prevent deleting it until it has been disabled everywhere?

The former might lead to admins accidentally deleting rules they didn't realize were still in use. The latter might make it really annoying to delete. Maybe there could be a --force option or something as a compromise.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions