Should different user authenticated be a server error? #8557
Unanswered
alechenninger
asked this question in
Q&A
Replies: 1 comment
-
|
I opened a PR for it #8603 |
Beta Was this translation helpful? Give feedback.
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
-
I was investigating a 500 error in our server logs and came across this one. From what I can tell, this is semantically in the "bad request" category and not an internal server error (there is no bug or operational problem for me to fix).
In AuthenticationProcessor:
I traced this back to https://issues.redhat.com/browse/KEYCLOAK-5567 and I wonder if this one was just a mistake as the issue is about errors which should be 4xx errors and all the other errors changed in that PR (with one exception that isn't in the code base anymore) were changed to be 4xx errors.
Is there a reason to keep this as an internal server error, or is there a reason not to change this to BAD_REQUEST?
I'll happily submit a small PR if this sounds appropriate. Thanks!
Beta Was this translation helpful? Give feedback.
All reactions