Change default location for storage.conf to... #1221
Conversation
|
Looks like I broke the darwin build - I'll update the PR shortly |
0f579cc to
fdcda1f
Compare
|
|
||
| // defaultConfigFile path to the system wide storage.conf file | ||
| var ( | ||
| defaultConfigFile = "/usr/local/share/containers/storage.conf" |
There was a problem hiding this comment.
should this be /usr/local/containers/storage.conf to match https://github.com/containers/storage/pull/1221/files#diff-3e70e441de9baa998963aaec77ca4cfe228f061b38d08eda62f28bdc53e3fdcbR8
There was a problem hiding this comment.
I think the example conf file should change instead. Generally, this kind of thing tends to live either in /usr/local/share or /usr/local/etc with any file likely to be changed locally strongly preferred to be in /usr/local/etc.
There was a problem hiding this comment.
I changed storage.conf-freebsd to match the compiled in default
There was a problem hiding this comment.
THat works for me, I was mostly concerned about the difference between the two. Thanks @dfr
... /usr/local/etc/containers on FreeBSD Signed-off-by: Doug Rabson <[email protected]>
|
LGTM |
|
@giuseppe PTAL |
|
LGTM |
Change default location for storage.conf to... Signed-off-by: Daniel J Walsh <[email protected]>
... /usr/local/etc/containers on FreeBSD
Signed-off-by: Doug Rabson [email protected]