Thanks to visit codestin.com
Credit goes to github.com

Skip to content

added ability to ignore sides on autocrop#924

Merged
hipstersmoothie merged 2 commits intojimp-dev:masterfrom
cbanfiel:master
Aug 8, 2020
Merged

added ability to ignore sides on autocrop#924
hipstersmoothie merged 2 commits intojimp-dev:masterfrom
cbanfiel:master

Conversation

@cbanfiel
Copy link
Contributor

@cbanfiel cbanfiel commented Aug 7, 2020 •
edited by hipstersmoothie
Loading

What's Changing and Why

Added the ability for users to ignore certain sides while autocropping, I needed to have this feature for a work project so I figured it might be useful for others as well.

What else might be affected

Nothing, just allowing the autocrop function to take in an ignoreSides object for more specific crops.

Example

image.autocrop({ cropOnlyFrames: false, ignoreSides:{north: true, west:true}})
(will ignore cropping north and west sides)

Tasks

  • Add tests
  • Update Documentation
  • Update jimp.d.ts
  • Add SemVer Label
📦 Published PR as canary version: 0.15.1-canary.924.1021.0

✨ Test out this PR locally via:

npm install @jimp/[email protected]
npm install @jimp/[email protected]
npm install @jimp/[email protected]
npm install [email protected]
npm install @jimp/[email protected]
npm install @jimp/[email protected]
npm install @jimp/[email protected]
npm install @jimp/[email protected]
npm install @jimp/[email protected]
npm install @jimp/[email protected]
npm install @jimp/[email protected]
npm install @jimp/[email protected]
npm install @jimp/[email protected]
npm install @jimp/[email protected]
npm install @jimp/[email protected]
npm install @jimp/[email protected]
npm install @jimp/[email protected]
npm install @jimp/[email protected]
npm install @jimp/[email protected]
npm install @jimp/[email protected]
npm install @jimp/[email protected]
npm install @jimp/[email protected]
npm install @jimp/[email protected]
npm install @jimp/[email protected]
npm install @jimp/[email protected]
npm install @jimp/[email protected]
npm install @jimp/[email protected]
npm install @jimp/[email protected]
npm install @jimp/[email protected]
npm install @jimp/[email protected]
npm install @jimp/[email protected]
npm install @jimp/[email protected]
npm install @jimp/[email protected]
npm install @jimp/[email protected]
# or 
yarn add @jimp/[email protected]
yarn add @jimp/[email protected]
yarn add @jimp/[email protected]
yarn add [email protected]
yarn add @jimp/[email protected]
yarn add @jimp/[email protected]
yarn add @jimp/[email protected]
yarn add @jimp/[email protected]
yarn add @jimp/[email protected]
yarn add @jimp/[email protected]
yarn add @jimp/[email protected]
yarn add @jimp/[email protected]
yarn add @jimp/[email protected]
yarn add @jimp/[email protected]
yarn add @jimp/[email protected]
yarn add @jimp/[email protected]
yarn add @jimp/[email protected]
yarn add @jimp/[email protected]
yarn add @jimp/[email protected]
yarn add @jimp/[email protected]
yarn add @jimp/[email protected]
yarn add @jimp/[email protected]
yarn add @jimp/[email protected]
yarn add @jimp/[email protected]
yarn add @jimp/[email protected]
yarn add @jimp/[email protected]
yarn add @jimp/[email protected]
yarn add @jimp/[email protected]
yarn add @jimp/[email protected]
yarn add @jimp/[email protected]
yarn add @jimp/[email protected]
yarn add @jimp/[email protected]
yarn add @jimp/[email protected]
yarn add @jimp/[email protected]

@hipstersmoothie
Copy link
Collaborator

hipstersmoothie commented Aug 7, 2020

@cbanfiel can you fix the lint errors? also please try to add a test. thank you!

@cbanfiel
Copy link
Contributor Author

cbanfiel commented Aug 7, 2020

Added tests and fixed lint issues. Thanks

@hipstersmoothie hipstersmoothie added the minor Increment the minor version when merged label Aug 8, 2020
@hipstersmoothie hipstersmoothie merged commit e67d683 into jimp-dev:master Aug 8, 2020
@hipstersmoothie
Copy link
Collaborator

hipstersmoothie commented Aug 8, 2020

🚀 PR was released in v0.16.0 🚀

@hipstersmoothie hipstersmoothie added the released This issue/pull request has been released. label Aug 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

minor Increment the minor version when merged released This issue/pull request has been released.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@cbanfiel @hipstersmoothie