Relabel,Chcon: do process the root entry last #165
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Commit 8501cfd does not guarantee that the root entry is processed last -- due to parallel nature of the pwalk it one of the last to be processed, but might be not the last one. Rewrite the code to process the root entry after all the others are done. Remove the test for root entry being last as the last = p assignment is racy, and this is now very obvious from the code that the root entry is indeed the last one. Fixes: 8501cfd Signed-off-by: Kir Kolyshkin <[email protected]>
Signed-off-by: Kir Kolyshkin <[email protected]>
Signed-off-by: Kir Kolyshkin <[email protected]>
Collaborator
Author
|
Once merged, we need to
|
Collaborator
|
@haircommander @thaJeztah PTAL |
|
LGTM |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit 8501cfd (PR #161) does not guarantee that the root entry
is processed last -- due to parallel nature of the pwalk it one of the
last to be processed, but might be not the last one.
Rewrite the code to process the root entry after all the others
are done.
Remove the test for root entry being last as the
last = passignmentis racy, and this is now very obvious from the code that the root entry
is indeed the last one.
Fixes: 8501cfd 🤦🏻
While at it:
-raceflag