Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@maximeperraultdev
Copy link
Collaborator

Related Pull Requests & Issues


  • Tests E2E (Cypress)

@tristanrobert
Copy link
Contributor

tristanrobert commented Oct 16, 2025

Snyk checks have passed. No issues have been found so far.

Status Scanner Critical High Medium Low Total (0)
Open Source Security 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

@maximeperraultdev maximeperraultdev force-pushed the maxime/feat/2541/add_vessel_search branch from 19eea57 to 4227cce Compare October 16, 2025 15:36
@maximeperraultdev maximeperraultdev force-pushed the maxime/feat/2541/add_vessel_search branch from 154f7de to 64a8203 Compare October 27, 2025 08:47
@maximeperraultdev maximeperraultdev force-pushed the maxime/feat/2541/add_vessel_search branch 3 times, most recently from 63b5403 to 6fbe08d Compare October 27, 2025 10:49
@@ -0,0 +1,750 @@
insert into public.naf (code, label)
values ('01.11Z', 'Culture de céréales (à l''exception du riz), de légumineuses et de graines oléagineuses'),
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

c'est quoi naf et d'où viennent ces données?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

le NAF est la nomenclature d'activité francaise que l'on peut retrouver sur le site de l'INSEE.

https://www.insee.fr/fr/information/2120875 (sous-classe)

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

idem pour las status légaux

const [debouncedQuery] = useDebounce(query, 300)
const { options } = useVessels(debouncedQuery)

const vesselCustomSearch = new CustomSearch(options ?? [], ['label'])
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sur la maquette il est écrit qu'il faut pouvoir chercher sur le nom, le MMSI, l'immatriculation et l'imo

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done ✅

<MapMenuDialog.Body>
<VesselIdentity>
<dt>MMSI</dt>
<dd>{vessel.mmsi ?? UNKNOWN}</dd>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sur les maquettes il y a un -quand la donnée est vide (et non Inconnu)

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done ✅

@maximeperraultdev maximeperraultdev force-pushed the maxime/feat/2541/add_vessel_search branch from d594ae8 to d687e8b Compare October 29, 2025 11:13
@sonarqubecloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
3.5% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

@maximeperraultdev
Copy link
Collaborator Author

@claire2212 Il y a quelque changements par rapport à la maquette. La fiche navire est juste sous le champ de recherche

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Rechercher un navire - Carto

4 participants