-
Notifications
You must be signed in to change notification settings - Fork 26
Description
Describe the bug
I see a long list of errors and warnings in the prod log.
We really need to clean-up some of those and try to fix the PHP warning or PHP or Twig errors we see...
I could make 20+ GitHub Issues out of this single ticket, but that won't help us. And will only cause more overhead. See the list of warnings/errors below under "List of issues".
On which Mbin instance did you find the bug?
kbin.melroy.org
Which Mbin version was running on the instance?
1.7.1
To Reproduce
Steps to reproduce the behavior:
- Check-out the log:
tail -f var/log/prod-xx-x-x-x.log - And follow it for a while...
Expected behavior
Minimal amount of errors and warnings in the production log. Only some error messages make sense if there is a real error and we still want to keep reporting it to admin of the instance.
Let's just see how much we can resolve in the first 1.7.2 milestone..
List of issues
Directly from the production log output:
- the first - missing null check, see PR: Check if EntryComment is defined and not null #1129
{"message":"Uncaught PHP Exception Twig\\Error\\RuntimeError: \"Error rendering \"entry_comment\" component: Expected argument of type \"App\\Entity\\EntryComment\", \"null\" given at property path \"comment\".\" at view.html.twig line 49","context":{"exception":{"class":"Twig\\Error\\RuntimeError","message":"Error rendering \"entry_comment\" component: Expected argument of type \"App\\Entity\\EntryComment\", \"null\" given at property path \"comment\".","code":0,"file":"/var/www/kbin.melroy.org/html/templates/entry/comment/view.html.twig:49","previous":{"class":"Symfony\\Component\\PropertyAccess\\Exception\\InvalidTypeException","message":"Expected argument of type \"App\\Entity\\EntryComment\", \"null\" given at property path \"comment\".","code":0,"file":"/var/www/kbin.melroy.org/html/vendor/symfony/property-access/PropertyAccessor.php:203","previous":{"class":"TypeError","message":"Cannot assign null to property App\\Twig\\Components\\EntryCommentComponent::$comment of type App\\Entity\\EntryComment","code":0,"file":"/var/www/kbin.melroy.org/html/vendor/symfony/property-access/PropertyAccessor.php:520"}}}},"level":500,"level_name":"CRITICAL","channel":"request","datetime":"2024-09-12T12:18:16.360410+02:00","extra":{}}- the second Fix 2nd miscellaneous bug #1124
{"message":"Error thrown while handling message App\\Message\\ActivityPub\\Inbox\\ChainActivityMessage. Sending for retry #1 using 300000 ms delay. Error: \"Handling \"App\\Message\\ActivityPub\\Inbox\\ChainActivityMessage\" failed: An exception occurred while executing a query: SQLSTATE[23505]: Unique violation: 7 ERROR: duplicate key value violates unique constraint \"uniq_2b219d70904f155e\"\nDETAIL: Key (ap_id)=(https://lemmy.world/post/19549932) already exists.\"","context":{"class":"App\\Message\\ActivityPub\\Inbox\\ChainActivityMessage","message_id":null,"retryCount":1,"delay":300000,"error":"Handling \"App\\Message\\ActivityPub\\Inbox\\ChainActivityMessage\" failed: An exception occurred while executing a query: SQLSTATE[23505]: Unique violation: 7 ERROR: duplicate key value violates unique constraint \"uniq_2b219d70904f155e\"\nDETAIL: Key (ap_id)=(https://lemmy.world/post/19549932) already exists.","exception":{"class":"Symfony\\Component\\Messenger\\Exception\\HandlerFailedException","message":"Handling \"App\\Message\\ActivityPub\\Inbox\\ChainActivityMessage\" failed: An exception occurred while executing a query: SQLSTATE[23505]: Unique violation: 7 ERROR: duplicate key value violates unique constraint \"uniq_2b219d70904f155e\"\nDETAIL: Key (ap_id)=(https://lemmy.world/post/19549932) already exists.","code":7,"file":"/var/www/kbin.melroy.org/html/vendor/symfony/messenger/Middleware/HandleMessageMiddleware.php:124","previous":{"class":"Doctrine\\DBAL\\Exception\\UniqueConstraintViolationException","message":"An exception occurred while executing a query: SQLSTATE[23505]: Unique violation: 7 ERROR: duplicate key value violates unique constraint \"uniq_2b219d70904f155e\"\nDETAIL: Key (ap_id)=(https://lemmy.world/post/19549932) already exists.","code":7,"file":"/var/www/kbin.melroy.org/html/vendor/doctrine/dbal/src/Driver/API/PostgreSQL/ExceptionConverter.php:53","previous":{"class":"Doctrine\\DBAL\\Driver\\PDO\\Exception","message":"SQLSTATE[23505]: Unique violation: 7 ERROR: duplicate key value violates unique constraint \"uniq_2b219d70904f155e\"\nDETAIL: Key (ap_id)=(https://lemmy.world/post/19549932) already exists.","code":7,"file":"/var/www/kbin.melroy.org/html/vendor/doctrine/dbal/src/Driver/PDO/Exception.php:28","previous":{"class":"PDOException","message":"SQLSTATE[23505]: Unique violation: 7 ERROR: duplicate key value violates unique constraint \"uniq_2b219d70904f155e\"\nDETAIL: Key (ap_id)=(https://lemmy.world/post/19549932) already exists.","code":23505,"file":"/var/www/kbin.melroy.org/html/vendor/doctrine/dbal/src/Driver/PDO/Statement.php:130"}}}}},"level":300,"level_name":"WARNING","channel":"messenger","datetime":"2024-09-08T23:58:40.008877+02:00","extra":{}}- the third Fix 3rd miscellaneous bug #1120
{"message":"Warning: Undefined array key \"attributedTo\"","context":{"exception":{"class":"ErrorException","message":"Warning: Undefined array key \"attributedTo\"","code":0,"file":"/var/www/kbin.melroy.org/html/src/Service/ActivityPubManager.php:554"}},"level":400,"level_name":"ERROR","channel":"php","datetime":"2024-09-08T23:58:47.966836+02:00","extra":{}}
{"message":"Warning: Undefined array key \"attributedTo\"","context":{"exception":{"class":"ErrorException","message":"Warning: Undefined array key \"attributedTo\"","code":0,"file":"/var/www/kbin.melroy.org/html/src/Service/ActivityPubManager.php:582"}},"level":400,"level_name":"ERROR","channel":"php","datetime":"2024-09-08T23:58:48.338044+02:00","extra":{}}- the fourth Fix 4th miscellaneous bug #1121
{"message":"Warning: Undefined array key \"publicKey\"","context":{"exception":{"class":"ErrorException","message":"Warning: Undefined array key \"publicKey\"","code":0,"file":"/var/www/kbin.melroy.org/html/src/Service/ActivityPub/SignatureValidator.php:116"}},"level":400,"level_name":"ERROR","channel":"php","datetime":"2024-09-12T12:19:29.121860+02:00","extra":{}}
{"message":"Warning: Trying to access array offset on null","context":{"exception":{"class":"ErrorException","message":"Warning: Trying to access array offset on null","code":0,"file":"/var/www/kbin.melroy.org/html/src/Service/ActivityPub/SignatureValidator.php:116"}},"level":400,"level_name":"ERROR","channel":"php","datetime":"2024-09-12T12:19:29.122088+02:00","extra":{}}
{"message":"Unable to extract public key for 'https://mastodon.sdf.org/users/TomCox'.","context":{"user":"https://mastodon.sdf.org/users/TomCox"},"level":300,"level_name":"WARNING","channel":"app","datetime":"2024-09-12T12:19:29.122196+02:00","extra":{}}I added "feddit.de" to block list (in the admin panel). Why do I still see?
{"message":"ApHttpClient:getActorObject get fail: https://feddit.de/u/Hellschwarz, ex: Symfony\\Component\\HttpClient\\Exception\\TransportException: Could not resolve host: feddit.de for \"https://feddit.de/u/Hellschwarz\". - there was an exception while getting the content, Symfony\\Component\\HttpClient\\Exception\\TransportException: Could not resolve host: feddit.de for \"https://feddit.de/u/Hellschwarz\".","context":{"type":"ApHttpClient:getActorObject","address":"https://feddit.de/u/Hellschwarz","e":"Symfony\\Component\\HttpClient\\Exception\\TransportException","msg":"Could not resolve host: feddit.de for \"https://feddit.de/u/Hellschwarz\".","content":"there was an exception while getting the content, Symfony\\Component\\HttpClient\\Exception\\TransportException: Could not resolve host: feddit.de for \"https://feddit.de/u/Hellschwarz\"."},"level":400,"level_name":"ERROR","channel":"app","datetime":"2024-09-12T12:20:37.666017+02:00","extra":{}}
{"message":"Error thrown while handling message App\\Message\\ActivityPub\\UpdateActorMessage. Removing from transport after 7 retries. Error: \"Handling \"App\\Message\\ActivityPub\\UpdateActorMessage\" failed: Could not resolve host: feddit.de for \"https://feddit.de/u/Hellschwarz\".\"","context":{"class":"App\\Message\\ActivityPub\\UpdateActorMessage","message_id":null,"retryCount":7,"error":"Handling \"App\\Message\\ActivityPub\\UpdateActorMessage\" failed: Could not resolve host: feddit.de for \"https://feddit.de/u/Hellschwarz\".","exception":{"class":"Symfony\\Component\\Messenger\\Exception\\HandlerFailedException","message":"Handling \"App\\Message\\ActivityPub\\UpdateActorMessage\" failed: Could not resolve host: feddit.de for \"https://feddit.de/u/Hellschwarz\".","code":0,"file":"/var/www/kbin.melroy.org/html/vendor/symfony/messenger/Middleware/HandleMessageMiddleware.php:124","previous":{"class":"Symfony\\Component\\HttpClient\\Exception\\TransportException","message":"Could not resolve host: feddit.de for \"https://feddit.de/u/Hellschwarz\".","code":0,"file":"/var/www/kbin.melroy.org/html/vendor/symfony/http-client/Response/CommonResponseTrait.php:140"}}},"level":500,"level_name":"CRITICAL","channel":"messenger","datetime":"2024-09-12T12:20:37.666575+02:00","extra":{}}
{"message":"ApHttpClient:getActorObject get fail: https://feddit.de/u/Hellschwarz, ex: Symfony\\Component\\HttpClient\\Exception\\TransportException: Could not resolve host: feddit.de for \"https://feddit.de/u/Hellschwarz\". - there was an exception while getting the content, Symfony\\Component\\HttpClient\\Exception\\TransportException: Could not resolve host: feddit.de for \"https://feddit.de/u/Hellschwarz\".","context":{"type":"ApHttpClient:getActorObject","address":"https://feddit.de/u/Hellschwarz","e":"Symfony\\Component\\HttpClient\\Exception\\TransportException","msg":"Could not resolve host: feddit.de for \"https://feddit.de/u/Hellschwarz\".","content":"there was an exception while getting the content, Symfony\\Component\\HttpClient\\Exception\\TransportException: Could not resolve host: feddit.de for \"https://feddit.de/u/Hellschwarz\"."},"level":400,"level_name":"ERROR","channel":"app","datetime":"2024-09-12T12:20:37.991473+02:00","extra":{}}
{"message":"Error thrown while handling message App\\Message\\ActivityPub\\UpdateActorMessage. Sending for retry #1 using 1800000 ms delay. Error: \"Handling \"App\\Message\\ActivityPub\\UpdateActorMessage\" failed: Could not resolve host: feddit.de for \"https://feddit.de/u/Hellschwarz\".\"","context":{"class":"App\\Message\\ActivityPub\\UpdateActorMessage","message_id":3468087,"retryCount":1,"delay":1800000,"error":"Handling \"App\\Message\\ActivityPub\\UpdateActorMessage\" failed: Could not resolve host: feddit.de for \"https://feddit.de/u/Hellschwarz\".","exception":{"class":"Symfony\\Component\\Messenger\\Exception\\HandlerFailedException","message":"Handling \"App\\Message\\ActivityPub\\UpdateActorMessage\" failed: Could not resolve host: feddit.de for \"https://feddit.de/u/Hellschwarz\".","code":0,"file":"/var/www/kbin.melroy.org/html/vendor/symfony/messenger/Middleware/HandleMessageMiddleware.php:124","previous":{"class":"Symfony\\Component\\HttpClient\\Exception\\TransportException","message":"Could not resolve host: feddit.de for \"https://feddit.de/u/Hellschwarz\".","code":0,"file":"/var/www/kbin.melroy.org/html/vendor/symfony/http-client/Response/CommonResponseTrait.php:140"}}},"level":300,"level_name":"WARNING","channel":"messenger","datetime":"2024-09-12T12:20:37.992118+02:00","extra":{}}- the sixth: I also blocked kbin.social. Why is this still happening? Fix 6th miscellaneous bug #1125
{"message":"Error thrown while handling message App\\Message\\ActivityPub\\Inbox\\ChainActivityMessage. Removing from transport after 3 retries. Error: \"Handling \"App\\Message\\ActivityPub\\Inbox\\ChainActivityMessage\" failed: Invalid status code while getting: https://kbin.social/m/[email protected]/t/994217/-/comment/6435263 : 503, <html lang=\"en\" style=\"font-size: 100%\">\n<head>\n <title>Error 50x - kbin.social</title>\n <meta name=\"viewport\" content=\"width=device-width, initial-scale=1\">\n <meta name=\"keywords\"\n content=\"kbin, link aggregator, mikroblog, socialmedia, wykop, reddit, twitter, open source, fediverse, makigi\">\n <meta name=\"description\" content=\"Explore Fediverse\">\n <meta property=\"og:url\" content=\"https://kbin.social/asdf\">\n <meta property=\"og:type\" content=\"article\">\n <meta property=\"og:title\" content=\"Error 404 - kbin.social\">\n <meta property=\"og:description\" content=\"Explore Fediverse\">\n <meta property=\"og:image\" content=\"https://kbin.social/kbin-og.png\">\n <link rel=\"shortcut icon\" href=\"https://kbin.social/favicon.ico\">\n <link rel=\"icon\" href=\"https://kbin.social/favicon.ico\" sizes=\"any\">\n <link rel=\"icon\" href=\"https://kbin.social/favicon.svg\" type=\"image/svg+xml\">\n <link rel=\"stylesheet\" href=\"https://kbin.pub/kbin.css\">\n<body class=\"theme--kbin fix\"","context":{"class":"App\\Message\\ActivityPub\\Inbox\\ChainActivityMessage","message_id":3467688,"retryCount":3,"error":"Handling \"App\\Message\\ActivityPub\\Inbox\\ChainActivityMessage\" failed: Invalid status code while getting: https://kbin.social/m/[email protected]/t/994217/-/comment/6435263 : 503, <html lang=\"en\" style=\"font-size: 100%\">\n<head>\n <title>Error 50x - kbin.social</title>\n <meta name=\"viewport\" content=\"width=device-width, initial-scale=1\">\n <meta name=\"keywords\"\n content=\"kbin, link aggregator, mikroblog, socialmedia, wykop, reddit, twitter, open source, fediverse, makigi\">\n <meta name=\"description\" content=\"Explore Fediverse\">\n <meta property=\"og:url\" content=\"https://kbin.social/asdf\">\n <meta property=\"og:type\" content=\"article\">\n <meta property=\"og:title\" content=\"Error 404 - kbin.social\">\n <meta property=\"og:description\" content=\"Explore Fediverse\">\n <meta property=\"og:image\" content=\"https://kbin.social/kbin-og.png\">\n <link rel=\"shortcut icon\" href=\"https://kbin.social/favicon.ico\">\n <link rel=\"icon\" href=\"https://kbin.social/favicon.ico\" sizes=\"any\">\n <link rel=\"icon\" href=\"https://kbin.social/favicon.svg\" type=\"image/svg+xml\">\n <link rel=\"stylesheet\" href=\"https://kbin.pub/kbin.css\">\n<body class=\"theme--kbin fix","exception":{"class":"Symfony\\Component\\Messenger\\Exception\\HandlerFailedException","message":"Handling \"App\\Message\\ActivityPub\\Inbox\\ChainActivityMessage\" failed: Invalid status code while getting: https://kbin.social/m/[email protected]/t/994217/-/comment/6435263 : 503, <html lang=\"en\" style=\"font-size: 100%\">\n<head>\n <title>Error 50x - kbin.social</title>\n <meta name=\"viewport\" content=\"width=device-width, initial-scale=1\">\n <meta name=\"keywords\"\n content=\"kbin, link aggregator, mikroblog, socialmedia, wykop, reddit, twitter, open source, fediverse, makigi\">\n <meta name=\"description\" content=\"Explore Fediverse\">\n <meta property=\"og:url\" content=\"https://kbin.social/asdf\">\n <meta property=\"og:type\" content=\"article\">\n <meta property=\"og:title\" content=\"Error 404 - kbin.social\">\n <meta property=\"og:description\" content=\"Explore Fediverse\">\n <meta property=\"og:image\" content=\"https://kbin.social/kbin-og.png\">\n <link rel=\"shortcut icon\" href=\"https://kbin.social/favicon.ico\">\n <link rel=\"icon\" href=\"https://kbin.social/favicon.ico\" sizes=\"any\">\n <link rel=\"icon\" href=\"https://kbin.social/favicon.svg\" type=\"image/svg+xml\">\n <link rel=\"stylesheet\" href=\"https://kbin.pub/kbin.css\">\n<body class=\"theme--kbin fix","code":0,"file":"/var/www/kbin.melroy.org/html/vendor/symfony/messenger/Middleware/HandleMessageMiddleware.php:124","previous":{"class":"App\\Exception\\InvalidApPostException","message":"Invalid status code while getting: https://kbin.social/m/[email protected]/t/994217/-/comment/6435263 : 503, <html lang=\"en\" style=\"font-size: 100%\">\n<head>\n <title>Error 50x - kbin.social</title>\n <meta name=\"viewport\" content=\"width=device-width, initial-scale=1\">\n <meta name=\"keywords\"\n content=\"kbin, link aggregator, mikroblog, socialmedia, wykop, reddit, twitter, open source, fediverse, makigi\">\n <meta name=\"description\" content=\"Explore Fediverse\">\n <meta property=\"og:url\" content=\"https://kbin.social/asdf\">\n <meta property=\"og:type\" content=\"article\">\n <meta property=\"og:title\" content=\"Error 404 - kbin.social\">\n <meta property=\"og:description\" content=\"Explore Fediverse\">\n <meta property=\"og:image\" content=\"https://kbin.social/kbin-og.png\">\n <link rel=\"shortcut icon\" href=\"https://kbin.social/favicon.ico\">\n <link rel=\"icon\" href=\"https://kbin.social/favicon.ico\" sizes=\"any\">\n <link rel=\"icon\" href=\"https://kbin.social/favicon.svg\" type=\"image/svg+xml\">\n <link rel=\"stylesheet\" href=\"https://kbin.pub/kbin.css\">\n<body class=\"theme--kbin fix","code":0,"file":"/var/www/kbin.melroy.org/html/src/Service/ActivityPub/ApHttpClient.php:104"}}},"level":500,"level_name":"CRITICAL","channel":"messenger","datetime":"2024-09-12T12:38:53.000175+02:00","extra":{}}- the seventh: also maybe do not return the whole HTML page.. >< Fix 7th miscellaneous bug #1123
{"message":"could not retrieve all the dependencies of array{\"@context\":[\"https://join-lemmy.org/context.json\",\"https://www.w3.org/ns/activitystreams\"],\"type\":\"Note\",\"id\":\"https://lemmy.world/comment/12312933\",\"attributedTo\":\"https://lemmy.world/u/aaaa\",\"to\":[\"https://www.w3.org/ns/activitystreams#Public\"],\"cc\":[\"https://lemmy.world/c/memes\",\"https://piefed.social/u/socsa\"],\"content\":\"<p>The NSFW tag is part of the mechanism to curate the feed.</p>\\n<p>I’m not sure why people get offended by people wanting to use social media but not wanting to view content that can get them fired. If the content doesn’t bother you, then you shouldn’t filter NSFW content. It’s not like the NSFW tag is censoring the content and preventing you from seeing it if you click it.</p>\\n<p>For people with jobs, why not make it easier to filter the things that companies don’t like? It doesn’t affect you any.</p>\\n\",\"inReplyTo\":\"https://piefed.social/comment/2799685\",\"mediaType\":\"text/html\",\"source\":{\"content\":\"The NSFW tag is part of the mechanism to curate the feed. \\n\\nI'm not sure why people get offended by people wanting to use social media but not wanting to view content that can get them fired. If the content doesn't bother you, then you shouldn't filter NSFW content. It's not like the NSFW tag is censoring the content and preventing you from seeing it if you click it.\\n\\nFor people with jobs, why not make it easier to filter the things that companies don't like? It doesn't affect you any.\",\"mediaType\":\"text/markdown\"},\"published\":\"2024-09-12T05:15:44.456255Z\",\"updated\":\"2024-09-12T05:22:16.215331Z\",\"tag\":[{\"href\":\"https://piefed.social/u/socsa\",\"name\":\"@[email protected]\",\"type\":\"Mention\"}],\"distinguished\":false,\"audience\":\"https://lemmy.world/c/memes\"}","context":{"o":{"@context":["https://join-lemmy.org/context.json","https://www.w3.org/ns/activitystreams"],"type":"Note","id":"https://lemmy.world/comment/12312933","attributedTo":"https://lemmy.world/u/aaaa","to":["https://www.w3.org/ns/activitystreams#Public"],"cc":["https://lemmy.world/c/memes","https://piefed.social/u/socsa"],"content":"<p>The NSFW tag is part of the mechanism to curate the feed.</p>\n<p>I’m not sure why people get offended by people wanting to use social media but not wanting to view content that can get them fired. If the content doesn’t bother you, then you shouldn’t filter NSFW content. It’s not like the NSFW tag is censoring the content and preventing you from seeing it if you click it.</p>\n<p>For people with jobs, why not make it easier to filter the things that companies don’t like? It doesn’t affect you any.</p>\n","inReplyTo":"https://piefed.social/comment/2799685","mediaType":"text/html","source":{"content":"The NSFW tag is part of the mechanism to curate the feed. \n\nI'm not sure why people get offended by people wanting to use social media but not wanting to view content that can get them fired. If the content doesn't bother you, then you shouldn't filter NSFW content. It's not like the NSFW tag is censoring the content and preventing you from seeing it if you click it.\n\nFor people with jobs, why not make it easier to filter the things that companies don't like? It doesn't affect you any.","mediaType":"text/markdown"},"published":"2024-09-12T05:15:44.456255Z","updated":"2024-09-12T05:22:16.215331Z","tag":[{"href":"https://piefed.social/u/socsa","name":"@[email protected]","type":"Mention"}],"distinguished":false,"audience":"https://lemmy.world/c/memes"}},"level":400,"level_name":"ERROR","channel":"app","datetime":"2024-09-12T12:32:54.916901+02:00","extra":{}}- the eigth (BentiGorlich: same as the fourth)
{"message":"Warning: Trying to access array offset on null","context":{"exception":{"class":"ErrorException","message":"Warning: Trying to access array offset on null","code":0,"file":"/var/www/kbin.melroy.org/html/src/Service/ActivityPub/SignatureValidator.php:116"}},"level":400,"level_name":"ERROR","channel":"php","datetime":"2024-09-12T12:39:00.481703+02:00","extra":{}}- the nineth Fix 9th miscellaneous bug #1122
{"message":"Warning: Trying to access array offset on null","context":{"exception":{"class":"ErrorException","message":"Warning: Trying to access array offset on null","code":0,"file":"/var/www/kbin.melroy.org/html/src/Service/ActivityPubManager.php:290"}},"level":400,"level_name":"ERROR","channel":"php","datetime":"2024-09-12T12:33:45.029513+02:00","extra":{}}
{"message":"ApHttpClient:getActivityObject get fail: https://social.vivaldi.net/users/OutOfExileIDR/statuses/113105981784505849/activity, ex: App\\Exception\\InvalidApPostException: Invalid status code while getting: https://social.vivaldi.net/users/OutOfExileIDR/statuses/113105981784505849/activity : 404, {\"error\":\"Not Found\"} - {\"error\":\"Not Found\"}","context":{"type":"ApHttpClient:getActivityObject","address":"https://social.vivaldi.net/users/OutOfExileIDR/statuses/113105981784505849/activity","e":"App\\Exception\\InvalidApPostException","msg":"Invalid status code while getting: https://social.vivaldi.net/users/OutOfExileIDR/statuses/113105981784505849/activity : 404, {\"error\":\"Not Found\"}","content":"{\"error\":\"Not Found\"}"},"level":400,"level_name":"ERROR","channel":"app","datetime":"2024-09-12T12:33:50.288473+02:00","extra":{}}- the tenth - same as the 1st.
{"message":"Uncaught PHP Exception Twig\\Error\\RuntimeError: \"Error rendering \"entry_comment\" component: Expected argument of type \"App\\Entity\\EntryComment\", \"null\" given at property path \"comment\".\" at view.html.twig line 49","context":{"exception":{"class":"Twig\\Error\\RuntimeError","message":"Error rendering \"entry_comment\" component: Expected argument of type \"App\\Entity\\EntryComment\", \"null\" given at property path \"comment\".","code":0,"file":"/var/www/kbin.melroy.org/html/templates/entry/comment/view.html.twig:49","previous":{"class":"Symfony\\Component\\PropertyAccess\\Exception\\InvalidTypeException","message":"Expected argument of type \"App\\Entity\\EntryComment\", \"null\" given at property path \"comment\".","code":0,"file":"/var/www/kbin.melroy.org/html/vendor/symfony/property-access/PropertyAccessor.php:203","previous":{"class":"TypeError","message":"Cannot assign null to property App\\Twig\\Components\\EntryCommentComponent::$comment of type App\\Entity\\EntryComment","code":0,"file":"/var/www/kbin.melroy.org/html/vendor/symfony/property-access/PropertyAccessor.php:534"}}}},"level":500,"level_name":"CRITICAL","channel":"request","datetime":"2024-09-12T12:36:13.835930+02:00","extra":{}}- the eleventh - checking on empty/null image: Check on empty/null filePath image #1128
./bin/console mbin:cache:build23:13:28 CRITICAL [console] Error thrown while running command "mbin:cache:build". Message: "Liip\ImagineBundle\Command\ResolveCacheCommand::runCacheImageResolve(): Argument #1 ($image) must be of type string, null given, called in /var/www/kbin.melroy.org/html/vendor/liip/imagine-bundle/Command/ResolveCacheCommand.php on line 95" ["exception" => TypeError { …},"command" => "mbin:cache:build","message" => "Liip\ImagineBundle\Command\ResolveCacheCommand::runCacheImageResolve(): Argument #1 ($image) must be of type string, null given, called in /var/www/kbin.melroy.org/html/vendor/liip/imagine-bundle/Command/ResolveCacheCommand.php on line 95"]
{"message":"Uncaught Error: Liip\\ImagineBundle\\Command\\ResolveCacheCommand::runCacheImageResolve(): Argument #1 ($image) must be of type string, null given, called in /var/www/kbin.melroy.org/html/vendor/liip/imagine-bundle/Command/ResolveCacheCommand.php on line 95","context":{"exception":{"class":"TypeError","message":"Liip\\ImagineBundle\\Command\\ResolveCacheCommand::runCacheImageResolve(): Argument #1 ($image) must be of type string, null given, called in /var/www/kbin.melroy.org/html/vendor/liip/imagine-bundle/Command/ResolveCacheCommand.php on line 95","code":0,"file":"/var/www/kbin.melroy.org/html/vendor/liip/imagine-bundle/Command/ResolveCacheCommand.php:104"}},"level":500,"level_name":"CRITICAL","channel":"php","datetime":"2024-09-11T23:13:28.060044+02:00","extra":{}} - the 13th - Invalid CSRF token (could be cause of vote errors etc. In fact @Jerry-infosecexchange also reported this issue). PR: Disable CSRF checks on some most-used forms #1136 and another PR: Store sessions in DB + improve cookies/sessions #1145
Most seen CSRF IDs causing issues are:
- down_vote (previously called
vote) - up_vote (previously called
favourite) - boost
- subscribe
Possible solution directions:
- Removing Twig templating cache
- Remove CSRF tokens from these forms (no big risk with vote or subscribe manipulation via CSRF attacks)
- .. Any other ideas are welcome..?
Full stack trace
During my testing in DEV mode:
[2024-09-12T20:42:54.414611+02:00] request.ERROR: Uncaught PHP Exception Symfony\Component\HttpKernel\Exception\BadRequestHttpException: "Invalid CSRF token" at AbstractController.php line 39 {"exception":"[object] (Symfony\\Component\\HttpKernel\\Exception\\BadRequestHttpException(code: 0): Invalid CSRF token at /var/www/kbin.melroy.org/html/src/Controller/AbstractController.php:39)
[stacktrace]
#0 /var/www/kbin.melroy.org/html/src/Controller/FavouriteController.php(24): App\\Controller\\AbstractController->validateCsrf()
#1 /var/www/kbin.melroy.org/html/vendor/symfony/http-kernel/HttpKernel.php(183): App\\Controller\\FavouriteController->__invoke()
#2 /var/www/kbin.melroy.org/html/vendor/symfony/http-kernel/HttpKernel.php(76): Symfony\\Component\\HttpKernel\\HttpKernel->handleRaw()
#3 /var/www/kbin.melroy.org/html/vendor/symfony/http-kernel/Kernel.php(182): Symfony\\Component\\HttpKernel\\HttpKernel->handle()
#4 /var/www/kbin.melroy.org/html/vendor/symfony/runtime/Runner/Symfony/HttpKernelRunner.php(35): Symfony\\Component\\HttpKernel\\Kernel->handle()
#5 /var/www/kbin.melroy.org/html/vendor/autoload_runtime.php(29): Symfony\\Component\\Runtime\\Runner\\Symfony\\HttpKernelRunner->run()
#6 /var/www/kbin.melroy.org/html/public/index.php(7): require_once('...')
#7 {main}
"} []
[2024-09-12T20:42:54.657138+02:00] request.ERROR: Uncaught PHP Exception Symfony\Component\HttpKernel\Exception\BadRequestHttpException: "Invalid CSRF token" at AbstractController.php line 39 {"exception":"[object] (Symfony\\Component\\HttpKernel\\Exception\\BadRequestHttpException(code: 0): Invalid CSRF token at /var/www/kbin.melroy.org/html/src/Controller/AbstractController.php:39)
[stacktrace]
#0 /var/www/kbin.melroy.org/html/src/Controller/FavouriteController.php(24): App\\Controller\\AbstractController->validateCsrf()
#1 /var/www/kbin.melroy.org/html/vendor/symfony/http-kernel/HttpKernel.php(183): App\\Controller\\FavouriteController->__invoke()
#2 /var/www/kbin.melroy.org/html/vendor/symfony/http-kernel/HttpKernel.php(76): Symfony\\Component\\HttpKernel\\HttpKernel->handleRaw()
#3 /var/www/kbin.melroy.org/html/vendor/symfony/http-kernel/Kernel.php(182): Symfony\\Component\\HttpKernel\\HttpKernel->handle()
#4 /var/www/kbin.melroy.org/html/vendor/symfony/runtime/Runner/Symfony/HttpKernelRunner.php(35): Symfony\\Component\\HttpKernel\\Kernel->handle()
#5 /var/www/kbin.melroy.org/html/vendor/autoload_runtime.php(29): Symfony\\Component\\Runtime\\Runner\\Symfony\\HttpKernelRunner->run()
#6 /var/www/kbin.melroy.org/html/public/index.php(7): require_once('...')
#7 {main}
"} []
And from Jerry during PRD mode:
{"message":"Uncaught PHP Exception Symfony\\Component\\HttpKernel\\Exception\\BadRequestHttpException: \"Invalid CSRF token\" at AbstractController.php line 39","context":{"exception":{"class":"Symfony\\Component\\HttpKernel\\Exception\\BadRequestHttpException","message":"Invalid CSRF token","code":0,"file":"/var/www/mbin/src/Controller/AbstractController.php:39"}},"level":400,"level_name":"ERROR","channel":"request","datetime":"2024-09-12T18:54:45.620576+00:00","extra":{}}
{"message":"Uncaught PHP Exception Symfony\\Component\\HttpKernel\\Exception\\BadRequestHttpException: \"Invalid CSRF token\" at AbstractController.php line 39","context":{"exception":{"class":"Symfony\\Component\\HttpKernel\\Exception\\BadRequestHttpException","message":"Invalid CSRF token","code":0,"file":"/var/www/mbin/src/Controller/AbstractController.php:39"}},"level":400,"level_name":"ERROR","channel":"request","datetime":"2024-09-12T18:54:45.803347+00:00","extra":{}}
- 15th - During getActivityObject error, is returning the whole HTML page by a 404 request. Basically polluting the logging a too much. Don't log full html pages (stop error log pollution) #1134
{"message":"ApHttpClient:getActivityObject get fail: https://fedia.io/m/[email protected]/t/1164332/-/comment/7154817, ex: App\\Exception\\InvalidApPostException: Invalid status code while getting: https://fedia.io/m/[email protected]/t/1164332/-/comment/7154817 : 404, <!DOCTYPE html>\n<html lang=\"en\"\n style=\"font-size: 100%\">\n<head>\n
.. whole HTML page...
{"type":"ApHttpClient:getActivityObject","address":"https://fedia.io/m/[email protected]/t/1164332/-/comment/7154817","e":"App\\Exception\\InvalidApPostException","msg":"Invalid status code while getting: https://fedia.io/m/[email protected]/t/1164332/-/comment/7154817 : 404, <!DOCTYPE html>\n<html lang=\"en\"\n style=\"font-size: 100%\">\n<head>\n <meta charset=\"UTF-8\">\n <title>Error 404 - Fedia</title>\n\n <meta name=\"viewport\" content=\"width=device-width, initial-scale=1\">\n .. the whole HTML Page...- 16th - Also reduce the HTML content of this non-JSON content dump during DeliverMessage error (cause too much log pollution). PR: Reduce error pollution even more on post request failures #1140
{"message":"Error thrown while handling message App\\Message\\ActivityPub\\Outbox\\DeliverMessage. Removing from transport after 7 retries. Error: \"Handling \"App\\Message\\ActivityPub\\Outbox\\DeliverMessage\" failed: Post fail: https://lemmy.chitter.club/inbox, <!DOCTYPE html>\n<!--[if lt IE 7]> <html class=\"no-js ie6 oldie\" lang=\"en-US\"> <![endif]-->\n<!--[if IE 7]> <html class=\"no-js ie7 oldie\" lang=\"en-US\"> <![endif]-->\n<!--[if IE 8]> <html class=\"no-js ie8 oldie\" lang=\"en-US\"> <![endif]-->\n<!--[if gt IE 8]><!--> <html class=\"no-js\" lang=\"en-US\"> <!--<![endif]-->\n<head>\n<title>Attention Required! | Cloudflare</title>\n<meta charset=\"UTF-8\" />\n<meta http-equiv=\"Content-Type\" content=\"text/html; charset=UTF-8\" />\n<meta http-equiv=\"X-UA-Compatible\" content=\"IE=Edge\" />\n<meta name=\"robots\" content=\"noindex, nofollow\" />\n<meta name=\"viewport\" content=\"width=device-width,initial-scale=1\" />\n<link rel=\"stylesheet\" id=\"cf_styles-css\" href=\"/cdn-cgi/styles/cf.errors.css\" />\n<!--[if lt IE 9]><link rel=\"stylesheet\" id='cf_styles-ie-css' href=\"/cdn-cgi/styles/cf.errors.ie.css\" /><![endif]-->\n<style>body{margin:0;padding:0}</style>\n\n\n<!--[if gte IE 10]><!-->\n<script>\n if (!navigator.cookieEnabled) {\n window.addEventListener('DOMContentLoaded', f {\"@context\":\"https:\\/\\/www.w3.org\\/ns\\/activitystreams\",\"id\":\"https:\\/\\/kbin.melroy.org\\/f\\/object\\/010c3bd0-1b7a-4ddd-990a-c65ab7492034\",\"type\":\"Announce\",\"actor\":\"https:\\/\\/kbin.melroy.org\\/m\\/random\",\"object\":{\"@context\":[\"https:\\/\\/www.w3.org\\/ns\\/activitystreams\",{\"ostatus\":\"http:\\/\\/ostatus.org#\",\"atomUri\":\"ostatus:atomUri\",\"inReplyToAtomUri\":\"ostatus:inReplyToAtomUri\",\"conversation\":\"ostatus:conversation\",\"sensitive\":\"as:sensitive\",\"toot\":\"http:\\/\\/joinmastodon.org\\/ns#\",\"votersCount\":\"toot:votersCount\"}],\"id\":\"https:\\/\\/mastodon.social\\/users\\/nixCraft\\/statuses\\/113099788493600682#updates\\/1725948661\",\"type\":\"Update\",\"actor\":\"https:\\/\\/mastodon.social\\/users\\/nixCraft\",\"to\":[\"https:\\/\\/www.w3.org\\/ns\\/activitystreams#Public\"],\"object\":{\"id\":\"https:\\/\\/mastodon.social\\/users\\/nixCraft\\/statuses\\/113099788493600682\",\"type\":\"Question\",\"summary\":null,\"inReplyTo\":null,\"published\":\"2024-09-08T03:23:35Z\",\"url\":\"https:\\/\\/mastodon.social\\/@nixCraft\\/113099788493600682\",\"attributedTo\":\"https:\\/\\/mastodon.social\\/users\\/nixCraft\",\"to\":[\"https:\\/\\/www.w3.org\\/ns\\/activitystreams#Public\"],\"cc\":[\"https:\\/\\/mastodon.social\\/users\\/nixCraft\\/followers\"],\"sensitive\":false,\"atomUri\":\"https:\\/\\/mastodon.social\\/users\\/nixCraft\\/statuses\\/113099788493600682\",\"inReplyToAtomUri\":null,\"conversation\":\"tag:mastodon.social,2024-09-08:objectId=794215693:objectType=Conversation\",\"content\":\"<p>Poll \\ud83e\\udee3<\\/p>\",\"contentMap\":{\"en\":\"<p>Poll \\ud83e\\udee3<\\/p>\"},\"endTime\":\"2024-09-11T03:23:35Z\",\"votersCount\":715,\"attachment\":[],\"tag\":[],\"replies\":{\"id\":\"https:\\/\\/mastodon.social\\/users\\/nixCraft\\/statuses\\/1130 ..... Full HTML......."}- 23rd - Language string in URL / Select query....
invalid input syntax for type integer: "el"(el is a language literal) - PR: Add stricter requirements to existing routes #1150
{"message":"Uncaught PHP Exception Doctrine\\DBAL\\Exception\\DriverException: \"An exception occurred while executing a query: SQLSTATE[22P02]: Invalid text representation: 7 ERROR: invalid input syntax for type integer: \"el\"\nCONTEXT: unnamed portal parameter $1 = '...'\" at ExceptionConverter.php line 87","context":{"exception":{"class":"Doctrine\\DBAL\\Exception\\DriverException","message":"An exception occurred while executing a query: SQLSTATE[22P02]: Invalid text representation: 7 ERROR: invalid input syntax for type integer: \"el\"\nCONTEXT: unnamed portal parameter $1 = '...'","code":7,"file":"/var/www/kbin.melroy.org/html/vendor/doctrine/dbal/src/Driver/API/PostgreSQL/ExceptionConverter.php:87","previous":{"class":"Doctrine\\DBAL\\Driver\\PDO\\Exception","message":"SQLSTATE[22P02]: Invalid text representation: 7 ERROR: invalid input syntax for type integer: \"el\"\nCONTEXT: unnamed portal parameter $1 = '...'","code":7,"file":"/var/www/kbin.melroy.org/html/vendor/doctrine/dbal/src/Driver/PDO/Exception.php:28","previous":{"class":"PDOException","message":"SQLSTATE[22P02]: Invalid text representation: 7 ERROR: invalid input syntax for type integer: \"el\"\nCONTEXT: unnamed portal parameter $1 = '...'","code":22,"file":"/var/www/kbin.melroy.org/html/vendor/doctrine/dbal/src/Driver/PDO/Statement.php:130"}}}},"level":500,"level_name":"CRITICAL","channel":"request","datetime":"2024-09-29T13:05:17.247414+02:00","extra":{}}
{"message":"Uncaught PHP Exception Doctrine\\DBAL\\Exception\\DriverException: \"An exception occurred while executing a query: SQLSTATE[22P02]: Invalid text representation: 7 ERROR: invalid input syntax for type integer: \"es\"\nCONTEXT: unnamed portal parameter $1 = '...'\" at ExceptionConverter.php line 87","context":{"exception":{"class":"Doctrine\\DBAL\\Exception\\DriverException","message":"An exception occurred while executing a query: SQLSTATE[22P02]: Invalid text representation: 7 ERROR: invalid input syntax for type integer: \"es\"\nCONTEXT: unnamed portal parameter $1 = '...'","code":7,"file":"/var/www/kbin.melroy.org/html/vendor/doctrine/dbal/src/Driver/API/PostgreSQL/ExceptionConverter.php:87","previous":{"class":"Doctrine\\DBAL\\Driver\\PDO\\Exception","message":"SQLSTATE[22P02]: Invalid text representation: 7 ERROR: invalid input syntax for type integer: \"es\"\nCONTEXT: unnamed portal parameter $1 = '...'","code":7,"file":"/var/www/kbin.melroy.org/html/vendor/doctrine/dbal/src/Driver/PDO/Exception.php:28","previous":{"class":"PDOException","message":"SQLSTATE[22P02]: Invalid text representation: 7 ERROR: invalid input syntax for type integer: \"es\"\nCONTEXT: unnamed portal parameter $1 = '...'","code":22,"file":"/var/www/kbin.melroy.org/html/vendor/doctrine/dbal/src/Driver/PDO/Statement.php:130"}}}},"level":500,"level_name":"CRITICAL","channel":"request","datetime":"2024-09-29T13:05:32.198035+02:00","extra":{}}
{"message":"Uncaught PHP Exception Doctrine\\DBAL\\Exception\\DriverException: \"An exception occurred while executing a query: SQLSTATE[22P02]: Invalid text representation: 7 ERROR: invalid input syntax for type integer: \"pt_BR\"\nCONTEXT: unnamed portal parameter $1 = '...'\" at ExceptionConverter.php line 87","context":{"exception":{"class":"Doctrine\\DBAL\\Exception\\DriverException","message":"An exception occurred while executing a query: SQLSTATE[22P02]: Invalid text representation: 7 ERROR: invalid input syntax for type integer: \"pt_BR\"\nCONTEXT: unnamed portal parameter $1 = '...'","code":7,"file":"/var/www/kbin.melroy.org/html/vendor/doctrine/dbal/src/Driver/API/PostgreSQL/ExceptionConverter.php:87","previous":{"class":"Doctrine\\DBAL\\Driver\\PDO\\Exception","message":"SQLSTATE[22P02]: Invalid text representation: 7 ERROR: invalid input syntax for type integer: \"pt_BR\"\nCONTEXT: unnamed portal parameter $1 = '...'","code":7,"file":"/var/www/kbin.melroy.org/html/vendor/doctrine/dbal/src/Driver/PDO/Exception.php:28","previous":{"class":"PDOException","message":"SQLSTATE[22P02]: Invalid text representation: 7 ERROR: invalid input syntax for type integer: \"pt_BR\"\nCONTEXT: unnamed portal parameter $1 = '...'","code":22,"file":"/var/www/kbin.melroy.org/html/vendor/doctrine/dbal/src/Driver/PDO/Statement.php:130"}}}},"level":500,"level_name":"CRITICAL","channel":"request","datetime":"2024-09-29T13:24:05.185252+02:00","extra":{}}
{"message":"Uncaught PHP Exception Doctrine\\DBAL\\Exception\\DriverException: \"An exception occurred while executing a query: SQLSTATE[22P02]: Invalid text representation: 7 ERROR: invalid input syntax for type integer: \"pt\"\nCONTEXT: unnamed portal parameter $1 = '...'\" at ExceptionConverter.php line 87","context":{"exception":{"class":"Doctrine\\DBAL\\Exception\\DriverException","message":"An exception occurred while executing a query: SQLSTATE[22P02]: Invalid text representation: 7 ERROR: invalid input syntax for type integer: \"pt\"\nCONTEXT: unnamed portal parameter $1 = '...'","code":7,"file":"/var/www/kbin.melroy.org/html/vendor/doctrine/dbal/src/Driver/API/PostgreSQL/ExceptionConverter.php:87","previous":{"class":"Doctrine\\DBAL\\Driver\\PDO\\Exception","message":"SQLSTATE[22P02]: Invalid text representation: 7 ERROR: invalid input syntax for type integer: \"pt\"\nCONTEXT: unnamed portal parameter $1 = '...'","code":7,"file":"/var/www/kbin.melroy.org/html/vendor/doctrine/dbal/src/Driver/PDO/Exception.php:28","previous":{"class":"PDOException","message":"SQLSTATE[22P02]: Invalid text representation: 7 ERROR: invalid input syntax for type integer: \"pt\"\nCONTEXT: unnamed portal parameter $1 = '...'","code":22,"file":"/var/www/kbin.melroy.org/html/vendor/doctrine/dbal/src/Driver/PDO/Statement.php:130"}}}},"level":500,"level_name":"CRITICAL","channel":"request","datetime":"2024-09-29T13:27:07.804965+02:00","extra":{}}
{"message":"Uncaught PHP Exception Doctrine\\DBAL\\Exception\\DriverException: \"An exception occurred while executing a query: SQLSTATE[22P02]: Invalid text representation: 7 ERROR: invalid input syntax for type integer: \"el\"\nCONTEXT: unnamed portal parameter $1 = '...'\" at ExceptionConverter.php line 87","context":{"exception":{"class":"Doctrine\\DBAL\\Exception\\DriverException","message":"An exception occurred while executing a query: SQLSTATE[22P02]: Invalid text representation: 7 ERROR: invalid input syntax for type integer: \"el\"\nCONTEXT: unnamed portal parameter $1 = '...'","code":7,"file":"/var/www/kbin.melroy.org/html/vendor/doctrine/dbal/src/Driver/API/PostgreSQL/ExceptionConverter.php:87","previous":{"class":"Doctrine\\DBAL\\Driver\\PDO\\Exception","message":"SQLSTATE[22P02]: Invalid text representation: 7 ERROR: invalid input syntax for type integer: \"el\"\nCONTEXT: unnamed portal parameter $1 = '...'","code":7,"file":"/var/www/kbin.melroy.org/html/vendor/doctrine/dbal/src/Driver/PDO/Exception.php:28","previous":{"class":"PDOException","message":"SQLSTATE[22P02]: Invalid text representation: 7 ERROR: invalid input syntax for type integer: \"el\"\nCONTEXT: unnamed portal parameter $1 = '...'","code":22,"file":"/var/www/kbin.melroy.org/html/vendor/doctrine/dbal/src/Driver/PDO/Statement.php:130"}}}},"level":500,"level_name":"CRITICAL","channel":"request","datetime":"2024-09-29T13:28:07.306013+02:00","extra":{}}
See also: #1072 (which I will not mention here)