Fix delivering to oneself #1211
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the `DeliverManager` tries to deliver to the local server prevent that and issue a warning
|
Do you want an approval and merge? Or do you want them to test the branch first? |
melroy89
approved these changes
Nov 8, 2024
|
I think we can just merge it as it is a good change either way... Even if it is a last minute failsafe... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the
DeliverManagertries to deliver to the local server prevent that and issue a warningI am really not sure if that is the issue at hand for @Jerry-infosecexchange and @jwr1 but it is the only thing I can think of and it is theoretically possible...