Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@IllianiBird
Copy link
Collaborator

Dev Notes

This PR just adds a missing Nullable tag to getExtraDataValue

…or improved code readability.

- Ensured consistent null-check handling for certain parameters (e.g., `surname`, `bloodname`) by adding default values where applicable.
@IllianiBird IllianiBird added the Refactoring Non-functional changes for improving the code of the project label Apr 27, 2025
@IllianiBird IllianiBird self-assigned this Apr 27, 2025
@codecov
Copy link

codecov bot commented Apr 27, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 30.31%. Comparing base (92363bf) to head (54759af).
Report is 6 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #6936      +/-   ##
============================================
- Coverage     30.32%   30.31%   -0.01%     
+ Complexity    15814    15809       -5     
============================================
  Files          2886     2886              
  Lines        283127   283127              
  Branches      49327    49327              
============================================
- Hits          85848    85835      -13     
- Misses       191680   191694      +14     
+ Partials       5599     5598       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@rjhancock rjhancock requested a review from a team as a code owner April 27, 2025 22:56
@rjhancock
Copy link
Collaborator

To save some headache later... go ahead and modify the history.txt file with this PR. it'll save work later.

@IllianiBird IllianiBird changed the title Added Missing Nullable Tag to getExtraDataValue Fix: Added Missing Nullable Tag to getExtraDataValue Apr 30, 2025
@Scoppio Scoppio merged commit d6cc3da into MegaMek:master Apr 30, 2025
6 checks passed
@IllianiBird IllianiBird deleted the nullBloodnameCheck branch June 7, 2025 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Refactoring Non-functional changes for improving the code of the project

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants