Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Autoresolve support #6208

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Nov 29, 2024
Merged

Autoresolve support #6208

merged 4 commits into from
Nov 29, 2024

Conversation

@Scoppio
Copy link
Collaborator

@Scoppio Scoppio commented Nov 18, 2024 •
edited
Loading

Extracts interface for some "end of game" events, this small necessary change is necessary for the implementation of an autoresolve feature that integrates with the Resolve Scenario wizard.

MegaMek/mekhq#5155

@Scoppio Scoppio self-assigned this Nov 18, 2024
@HammerGS
Copy link
Member

HammerGS commented Nov 23, 2024

Is this still in Development, also could we get a description so we know what it does.

HammerGS
HammerGS requested changes Nov 23, 2024
View reviewed changes
Copy link
Member

@HammerGS HammerGS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See note regarding Description and status

@HammerGS HammerGS marked this pull request as draft November 24, 2024 22:41
@Scoppio Scoppio requested a review from HammerGS November 25, 2024 03:42
@Scoppio
Copy link
Collaborator Author

Scoppio commented Nov 25, 2024

See note regarding Description and status
Added the information. This pull request is necessary for all the multiple works I am doing on auto-resolve right now. Also this is very minor, non-functional and does not cause any kind of effects anywhere else.

github-advanced-security[bot]
github-advanced-security bot found potential problems Nov 25, 2024
View reviewed changes
megamek/src/megamek/common/event/GameListener.java
void gameVictory(GameVictoryEvent e);

void gameVictory(PostGameResolution e);

Check notice

Code scanning / CodeQL

Useless parameter Note

The parameter 'e' is never used.
@codecov
Copy link

codecov bot commented Nov 25, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (master@61d2def). Learn more about missing BASE report.
Report is 49 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff            @@
##             master    #6208   +/-   ##
=========================================
  Coverage          ?   29.01%           
  Complexity        ?    13984           
=========================================
  Files             ?     2649           
  Lines             ?   268128           
  Branches          ?    47723           
=========================================
  Hits              ?    77801           
  Misses            ?   186440           
  Partials          ?     3887

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Scoppio Scoppio marked this pull request as ready for review November 27, 2024 01:03
@Scoppio
Copy link
Collaborator Author

Scoppio commented Nov 27, 2024

See note regarding Description and status

I talked with Illiani, we will move forward with this one, as the other type of autoresolve I am planning is in the back burner and may take longer than expected.

@HammerGS HammerGS merged commit 2fc1f33 into MegaMek:master Nov 29, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@HammerGS HammerGS Awaiting requested review from HammerGS

Assignees

@Scoppio Scoppio

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Scoppio @HammerGS