Victory and MM scenarios #6228
Merged
Victory and MM scenarios #6228
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # megamek/src/megamek/server/victory/Victory.java
# Conflicts: # megamek/data/scenarios/Kell Hounds/LoweringTheBoom/LoweringTheBoom.mms # megamek/docs/Scenarios/ScenarioV2 HowTo.mms # megamek/src/megamek/common/Game.java # megamek/src/megamek/common/scenario/ScenarioV2.java # megamek/src/megamek/server/victory/VictoryHelper.java
…' into Story-message-6-victory-and-scenarios
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6228 +/- ##
=========================================
Coverage ? 29.00%
Complexity ? 13983
=========================================
Files ? 2652
Lines ? 268195
Branches ? 47729
=========================================
Hits ? 77800
Misses ? 186511
Partials ? 3884 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates victory handling to recognize victory/draw by scenario events correctly. This should have no effect on victory handling by game options. There's a lot of updates to scenario definitions, helpful toString overrides & scenario parsing, but the main code changes are those of VictoryHelper.