Rolled Back #6381 #6384
Merged
Rolled Back #6381 #6384
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed the `resources` variable from static to instance-level to improve encapsulation. This ensures that each dialog can manage its own resources independently, avoiding potential conflicts in shared states.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6384 +/- ##
=========================================
Coverage 28.59% 28.60%
Complexity 14088 14088
=========================================
Files 2784 2784
Lines 273079 273079
Branches 48380 48380
=========================================
+ Hits 78100 78101 +1
+ Misses 190999 190997 -2
- Partials 3980 3981 +1 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed the
resourcesvariable back from static to instance-level.