Refactored Personality Characteristic Display in Personnel Table #4693
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed the formatting for Personality Characteristics to show the trait description first followed by its sign in parentheses. Also added 'INTELLIGENCE' to the IntegerStringSorter to maintain consistency with other numerical fields.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4693 +/- ##
============================================
- Coverage 10.76% 10.20% -0.57%
+ Complexity 5668 5661 -7
============================================
Files 948 948
Lines 132553 132553
Branches 19048 19048
============================================
- Hits 14272 13523 -749
- Misses 117041 117791 +750
+ Partials 1240 1239 -1 ☔ View full report in Codecov by Sentry. |
Added a minimum size of 1100x500 to CustomizePersonDialog to ensure consistent layout and prevent UI elements from being truncated.
# Conflicts: # MekHQ/src/mekhq/gui/enums/PersonnelTableModelColumn.java
|
Updated to account for name change project |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed the formatting for Personality Characteristics to show the trait description first followed by its sign in parentheses. Also added 'INTELLIGENCE' to the IntegerStringSorter to maintain consistency with other numerical fields.