Change Logger Level from Error to Warn for SPA Loader #4893
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adjusted the logging level from error to warn when restoring an SPA fails. This avoids an error dialog appearing whenever a character with a no-longer existing SPA is loaded. Instead, it will report to the log and advance to the next SPA.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4893 +/- ##
============================================
- Coverage 10.46% 10.45% -0.01%
+ Complexity 6017 6008 -9
============================================
Files 952 952
Lines 132755 132755
Branches 19308 19308
============================================
- Hits 13894 13884 -10
- Misses 117516 117521 +5
- Partials 1345 1350 +5 ☔ View full report in Codecov by Sentry. |
HammerGS
approved these changes
Sep 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adjusted the logging level from error to warn when restoring an SPA fails. This avoids an error dialog appearing whenever a character with a no-longer existing SPA is loaded. Instead, it will report to the log and advance to the next SPA.
Closes #4890