Fix #5028 and allow random camo to go into deeper directories #5035
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
On my mobile so can’t review, but thank you for fixing this |
| if (!allFiles.isEmpty()) { | ||
| File randomFile = allFiles.get(new Random().nextInt(allFiles.size())); | ||
| if ((null != allPaths) && (!allPaths.isEmpty())) { | ||
| Path randomPath = allPaths.get(new Random().nextInt(allPaths.size())); |
Check warning
Code scanning / CodeQL
Random used only once Warning
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5035 +/- ##
============================================
- Coverage 10.44% 10.43% -0.02%
- Complexity 6015 6018 +3
============================================
Files 950 952 +2
Lines 133511 133807 +296
Branches 19400 19428 +28
============================================
+ Hits 13948 13958 +10
- Misses 118217 118503 +286
Partials 1346 1346 ☔ View full report in Codecov by Sentry. |
IllianiBird
reviewed
Oct 12, 2024
IllianiBird
approved these changes
Oct 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The random camouflage picker was sometimes picking directories instead of files to use as camo for a group in a generated contract. It also wasn't going into all of the subdirectories, only the first level under the faction, so some files were getting left out. This fixes both of those problems.
It seems like Camoflauge or AbstractIcon should have some verification that the files you pass them exist, but...