Refactored JScrollPaneWithSpeed Constructor
#5147
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed the `JScrollPaneWithSpeed` constructor to take a null argument for the viewport. This was done to ensure proper initialization of the scrolling pane.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5147 +/- ##
=========================================
Coverage 10.53% 10.53%
+ Complexity 6041 6040 -1
=========================================
Files 956 956
Lines 134253 134264 +11
Branches 19501 19506 +5
=========================================
+ Hits 14142 14146 +4
- Misses 118760 118769 +9
+ Partials 1351 1349 -2 ☔ View full report in Codecov by Sentry. |
|
Looks good to me, likely a good fix to have regardles of changes to RSWD; that file still uses them. |
WeaverThree
approved these changes
Oct 28, 2024
HammerGS
approved these changes
Oct 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed the
JScrollPaneWithSpeedconstructor to take a null argument for the viewport. This was done to ensure proper initialization of the scrolling pane.This might be negated by some refactoring @WeaverThree is doing, but I had to make the change locally so I figured it was worth pushing.