Handled StratCon Scenario Placement Failure when All Coordinates Occupied #5141
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pied Added checks to handle scenarios where facilities or objectives could not be placed because all coordinates were occupied. Issued warnings and errors, and updated the `getUnoccupiedCoords` method to return null when placement is not possible.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5141 +/- ##
============================================
- Coverage 10.53% 10.53% -0.01%
- Complexity 6041 6043 +2
============================================
Files 956 956
Lines 134253 134276 +23
Branches 19501 19508 +7
============================================
+ Hits 14142 14144 +2
- Misses 118760 118780 +20
- Partials 1351 1352 +1 ☔ View full report in Codecov by Sentry. |
HammerGS
approved these changes
Oct 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added checks to handle scenarios where facilities or objectives could not be placed because all coordinates in a StratCon track were occupied. Issued warnings and errors, and updated the
getUnoccupiedCoordsmethod to return null when placement is not possible.It's worth noting that this is not a scenario that is likely to ever come up, because what are the chances we try to place a new scenario down on a track where every hex is occupied? In vanilla StratCon that scenario will never occur because
getUnoccupiedCoordsis only called at the beginning of a contract when a track is effectively empty.I'm currently working on a secret project that will require me to place events on the StratCon map. I'm planning to use
getUnoccupiedCoords, as I don't want stacked events, but that raises the chance of this exception occurring from 'none' to 'very low'. Prior to this PR, if that scenario did occur the client would end in an infinite loop.