Fixed StratCon Reinforcement Deployment Check #5157
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed redundant check for victory points in deployment eligibility. Previously we removed the automatic exchange of CVP to SP when reinforcing a non-Fight Stance'd force. However, this check was missed so will displace non-Fight forces even if the player has no SP. Now, those forces will only be visible if the player has SP adding visible value to the Fight stance.
Scoppio
reviewed
Nov 1, 2024
| return ReinforcementEligibilityType.FightLance; | ||
| } | ||
|
|
||
| // otherwise, the force requires support points / vps to deploy |
There was a problem hiding this comment.
Change in code make the commentary above it wrong, should be changed to match the code
There was a problem hiding this comment.
Oh good catch, thank you :)
HammerGS
approved these changes
Nov 3, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5157 +/- ##
============================================
- Coverage 10.53% 10.52% -0.02%
+ Complexity 6044 6039 -5
============================================
Files 956 956
Lines 134270 134345 +75
Branches 19501 19513 +12
============================================
- Hits 14149 14141 -8
- Misses 118769 118852 +83
Partials 1352 1352 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed redundant check for victory points in deployment eligibility. Previously we removed the automatic exchange of CVP to SP when reinforcing a non-Fight Stance'd force. However, this check was missed so would display non-Fight forces even if the player has no SP. Now, those forces will only be visible if the player has SP adding visible value to the Fight stance.