-
Notifications
You must be signed in to change notification settings - Fork 2k
Closed
Description
So we had a SwiftLint build phase for quite some time. Unfortunately, this build phase was a problem for Carthage users, so there is a PR to remove it (#1615) to fix some of the problems like #1458 and #1542.
The main problem is that the build phase is ran by Carthage as well. Quick had a similar issue and it seems to be resolved now. Relevant links: Quick#693, Quick#694 and Nimble#409.
Oh, and it would be awesome to update our CI workflow to separate testing Carthage integration without SwiftLint, so we can avoid similar situation in the future.
If there are any questions about this one let me know!
akolov, clementleroy, IgorBulyga and frederik-jacques