From 1003dcaa6c9ef88fc7aa363339a69366660a7e79 Mon Sep 17 00:00:00 2001 From: Jason Barnett Date: Thu, 28 Feb 2019 14:58:54 -0500 Subject: [PATCH] Correct API endpoint for project approvers --- lib/gitlab/client/merge_request_approvals.rb | 2 +- spec/gitlab/client/merge_request_approvals_spec.rb | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/lib/gitlab/client/merge_request_approvals.rb b/lib/gitlab/client/merge_request_approvals.rb index ce35f6ff2..bbbbbb2f5 100644 --- a/lib/gitlab/client/merge_request_approvals.rb +++ b/lib/gitlab/client/merge_request_approvals.rb @@ -28,7 +28,7 @@ def project_merge_request_approvals(project) # @option options [Boolean] :disable_overriding_approvers_per_merge_request(optional) Allow/Disallow overriding approvers per MR # @return [Gitlab::ObjectifiedHash] MR approval configuration information about the project def edit_project_merge_request_approvals(project, options = {}) - post("/projects/#{url_encode project}/approvals", body: options) + post("/projects/#{url_encode project}/approvers", body: options) end # Change allowed approvers and approver groups for a project diff --git a/spec/gitlab/client/merge_request_approvals_spec.rb b/spec/gitlab/client/merge_request_approvals_spec.rb index 38e42b1c3..be92b3bd8 100644 --- a/spec/gitlab/client/merge_request_approvals_spec.rb +++ b/spec/gitlab/client/merge_request_approvals_spec.rb @@ -21,13 +21,13 @@ describe '.edit_project_merge_request_approvals' do before do body = { approvals_before_merge: '3', reset_approvals_on_push: 'false', disable_overriding_approvers_per_merge_request: 'true' } - stub_post('/projects/1/approvals', 'project_merge_request_approvals').with(body: body) + stub_post('/projects/1/approvers', 'project_merge_request_approvals').with(body: body) @project_mr_approvals = Gitlab.edit_project_merge_request_approvals(1, approvals_before_merge: 3, reset_approvals_on_push: false, disable_overriding_approvers_per_merge_request: true) end it 'gets the correct resource' do body = { approvals_before_merge: '3', reset_approvals_on_push: 'false', disable_overriding_approvers_per_merge_request: 'true' } - expect(a_post('/projects/1/approvals') + expect(a_post('/projects/1/approvers') .with(body: body)).to have_been_made end