-
-
Notifications
You must be signed in to change notification settings - Fork 17
Description
@earnaud over on ropensci/EML#330 reported seeing a unit with the id molePerKilogram twice in the units list but with slightly different attributes. You can see it's defined twice:
Lines 1623 to 1627 in fe77f8f
| <unit id="molePerKilogram" name="molePerKilogram" unitType="amountOfSubstanceWeight" | |
| parentSI="molePerKilogram" multiplierToSI="1" abbreviation="mol/kg" | |
| udunitsSynonym="mole/kilogram"> | |
| <description>moles per kilogram</description> | |
| </unit> |
Lines 2017 to 2020 in fe77f8f
| <unit id="molePerKilogram" name="molePerKilogram" unitType="" parentSI="molePerKilogram" | |
| multiplierToSI="1" abbreviation="mol/kg" udunitsSynonym="mole/kilogram"> | |
| <description>micromoles per kilogram</description> | |
| </unit> |
The first time, it's grouped with <!--amountOfSubstanceWeight--> and the second time it's grouped with <!--amountPerMass-->.
It's also listed twice in the eml-unitTypeDefinitions.xsd file:
eml/xsd/eml-unitTypeDefinitions.xsd
Lines 378 to 379 in fe77f8f
| <xs:enumeration value="molePerKilogram"/> | |
| <xs:enumeration value="molePerKilogram"/> |
@mbjones, @mobb: Does this seem like a mistake to you too?
@earnaud also indicates there were other issues but I haven't figured out what those are just yet.
Once fixed, we need to issue a re-release of EML and emld. emld is where the schema files are shipped.