Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@scarlehoff
Copy link
Member

Just added the action from #703 to see whether it still works. If it does I'll open a new PR with #703.

@siranipour
Copy link
Contributor

Very nice, I much prefer the GitHub Actions interface so this is a welcomed change in my opinion anyway. Is there any way to check the master only actions execute correctly without having to merge?

@scarrazza
Copy link
Member

These 2 tests have already burned 10% of our quota... We should probably disable macos builds.

@Zaharid
Copy link
Contributor

Zaharid commented Aug 23, 2021

#1284 should also help with this eventually.

@scarlehoff
Copy link
Member Author

These 2 tests have already burned 10% of our quota... We should probably disable macos builds.

Once we go public we have infinity quota no?

@scarrazza
Copy link
Member

@scarlehoff yes

@scarlehoff
Copy link
Member Author

scarlehoff commented Aug 23, 2021

Cherry-picked from #703, I've commented out Mac OS for now. We can leave it like that until we make the repository public (#954) Since once of the previous commits worked for Mac we know that in its current form the workflow works...

As @siranipour the only thing missing is the master-only actions, the sooner we merge this the sooner we test them :P (and if some of them do not work... it won't be worse than Travis currently is -or isn't-)

@Zaharid
Copy link
Contributor

Zaharid commented Aug 23, 2021

Ok if this builds and someone (@siranipour ) can look at the docs, I suggest merging this ASAP.

@siranipour
Copy link
Contributor

Shall we modify docs in this PR or a new one?

@Zaharid
Copy link
Contributor

Zaharid commented Aug 23, 2021

This one, commiting directly or as in a review if you like.

Copy link
Contributor

@siranipour siranipour left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, feel free to ignore the runner.os suggestions

@scarlehoff
Copy link
Member Author

Btw, there's a million options for conda-incubator/setup-miniconda@v2 that might simplify the .yml file quite a bit. I'm torn about this because in its current form it is quite complicated but it works really well as a "recipe" one can use to run the entire thing in one's computer.

Also, it seems the runner.os doesn't work so I'll revert that change.

@Zaharid
Copy link
Contributor

Zaharid commented Aug 23, 2021

Ok I am merging this. As for the action, I share the sentiment that what we have is already done and it is a nice bit of self tested documentation.

@Zaharid Zaharid merged commit 97b0b79 into master Aug 23, 2021
@Zaharid Zaharid deleted the githubtest branch August 23, 2021 17:17
@Zaharid Zaharid added the devtools Build, automation and workflow label Oct 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

devtools Build, automation and workflow

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants