-
Notifications
You must be signed in to change notification settings - Fork 12
Add testing github action #1363
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Very nice, I much prefer the GitHub Actions interface so this is a welcomed change in my opinion anyway. Is there any way to check the |
|
These 2 tests have already burned 10% of our quota... We should probably disable macos builds. |
|
#1284 should also help with this eventually. |
Once we go public we have infinity quota no? |
|
@scarlehoff yes |
|
Cherry-picked from #703, I've commented out Mac OS for now. We can leave it like that until we make the repository public (#954) Since once of the previous commits worked for Mac we know that in its current form the workflow works... As @siranipour the only thing missing is the master-only actions, the sooner we merge this the sooner we test them :P (and if some of them do not work... it won't be worse than Travis currently is -or isn't-) |
|
Ok if this builds and someone (@siranipour ) can look at the docs, I suggest merging this ASAP. |
|
Shall we modify docs in this PR or a new one? |
|
This one, commiting directly or as in a review if you like. |
siranipour
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, feel free to ignore the runner.os suggestions
Co-authored-by: siranipour <[email protected]>
|
Btw, there's a million options for Also, it seems the |
|
Ok I am merging this. As for the action, I share the sentiment that what we have is already done and it is a nice bit of self tested documentation. |
Just added the action from #703 to see whether it still works. If it does I'll open a new PR with #703.