Remove nnfit references #1394
Merged
Remove nnfit references #1394
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RoyStegeman
reviewed
Aug 31, 2021
Co-authored-by: Roy Stegeman <[email protected]>
siranipour
reviewed
Aug 31, 2021
Co-authored-by: siranipour <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove references to
nnfitin then3fittutorial. The don't really make sense as 1) new people in the reference won't necessarily know aboutnnfit2) people from the outside cannot know.I also changed how the index looks in the
n3fitguide at https://docs.nnpdf.science/n3fit/index.html#n3fit-design because frankly it was horrendous.It deals with the outstanding problems of #1372