replacing travis with github workflow #703
Conversation
|
This is very nice. What does it mean no limits? Can I mine me some bitcoin? Why does the "remove homebrew" step take 15 minutes (https://github.com/NNPDF/nnpdf/pull/703/checks?check_run_id=557408059)? Do we need it at all? Can we use the same commands for both linux and mac? |
well, yes, up to 6h per job I think (https://help.github.com/en/actions/getting-started-with-github-actions/about-github-actions#usage-limits)
The mac build time oscillates. I have tried without the homebrew and it works, however I don't know why this step was in the travis build. I would love to get rid of that line, the SDK and conda installations (but I am afraid is not super easy, and I need a mac expert ;-p). |
|
I hope some mac expert could elucidate to me
|
The home brew I'm not sure because it's not usually installed by default.. perhaps this was something specific to the travis environments?
The simple line is regardless of what xcode you are running, you need the specific SDK detailed here to be able to compile with conda https://docs.conda.io/projects/conda-build/en/latest/resources/compiler-tools.html#macos-sdk they can't ship it with conda for legal reasons |
|
but that's to say I don't think you can ever get rid of the SDK stuff for MacOS unless they change how their compilers are working, which I find unlikely because it doesn't look like apple are going to suddenly become more relaxed about people shipping their base libraries |
|
@wilsonmr thanks, I will remove the homebrew. Now, concerning the macOS SDK, is it possible to use a version different from 10.9, for example the one already installed in the image? https://github.com/actions/virtual-environments/blob/master/images/macos/macos-10.15-Readme.md#installed-sdks |
|
as far as I'm aware no: #323 the mac compilers are built specifically against 10.9 |
|
Ok, then the last thing we could try to get rid is the miniconda installation. |
|
I have had that problem, but I don't remember where or how I solved it. |
|
Ah right, please have a look https://github.com/Zaharid/pylhapdf/blob/master/.github/workflows/main.yml |
|
In particular there is the |
|
OK, then we should try use that on both builds. |
|
Where can I find information on the images used by these workflows? |
|
Information about the images are in this repo https://github.com/actions/virtual-environments/blob/master/images/linux/Ubuntu1804-README.md It is interesting that this is also faster than Travis. Nice. |
|
This looks very good, not least because of the +78 −234 diffstat. We should update some documentation though. |
|
$ rg Travis still has a few hits in various docs. I'll work on that. |
.github/workflows/rules.yml
Outdated
| conda activate root | ||
| scp -i "$KEY" -o StrictHostKeyChecking=no\ | ||
| $CONDA_PREFIX/conda-bld/${{matrix.CONDA_OS}}/*.tar.bz2 \ | ||
| [email protected]:~/packages/conda-private/linux-64 |
There was a problem hiding this comment.
Did you test the uploading? This URL seems wrong.
There was a problem hiding this comment.
Thanks, fixed the url. I did not check the uploading process (the scp), but maybe we can debug that when merging to master?
|
I'd prefer to do the testing here. Both to confirm that the docs are right and indeed you can upload by removing that one line and to keep up with the proud righteous traditions of yesteryear. |
|
OK, this is working well including the uploads. |
|
Ok, please rebase -i to get rid of the typo commits and merge. This should be very useful! |
removing useless copy
Remove outdated mentions to Travis. Consolidate references to old CIs in the end rather than in the introduction. Remove an outdated section on the vp guide that is already well covered in the Sphinx docs. fixing typo testing full chain adding key for sphinx upload yeah, missing recursive copy moving the upload back to master
|
@scarrazza I am getting an error! |
|
I know, don't worry this should be fixed tomorrow. |
This PR addresses the issue #676 by replacing travis builds with github workflows. I have checked and our account does not have time/build limitations. This implementation replaces all travis builds, and its much faster, approx 15min per build.
The linux implementation is based on github ubuntu installation, which already comes with conda.
The macos implementation is similar to travis, I didn't manage to use the conda installation and SDK already shipped in the image. If someone wants to play is welcome.