-
Notifications
You must be signed in to change notification settings - Fork 72
Move tests to GPU #132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move tests to GPU #132
Conversation
Signed-off-by: Maximilian Jeblick <[email protected]>
Signed-off-by: Max Jeblick <[email protected]>
Signed-off-by: Max Jeblick <[email protected]>
Signed-off-by: Max Jeblick <[email protected]>
|
/ok to test c6383f2 |
Signed-off-by: Max Jeblick <[email protected]>
|
/ok to test f83914e |
Signed-off-by: Max Jeblick <[email protected]>
Signed-off-by: Max Jeblick <[email protected]>
|
/ok to test fa3e9c0 |
|
/ok to test f83914e |
@maxjeblick, there was an error processing your request: See the following link for more information: https://docs.gha-runners.nvidia.com/cpr/e/2/ |
Signed-off-by: Max Jeblick <[email protected]>
|
/ok to test 59f3156 |
Signed-off-by: Max Jeblick <[email protected]>
|
/ok to test 9eaf5a7 |
Signed-off-by: Max Jeblick <[email protected]>
|
/ok to test 92d6e0e |
Signed-off-by: Max Jeblick <[email protected]>
Signed-off-by: Max Jeblick <[email protected]>
|
/ok to test 4987ef9 |
Signed-off-by: Max Jeblick <[email protected]>
|
/ok to test 7ad2049 |
Signed-off-by: Max Jeblick <[email protected]>
|
/ok to test a58c28b |
|
Works now except for qfilter press |
|
/ok to test df1b283 |
Signed-off-by: Jack Yu <[email protected]>
|
/ok to test 5bd4b6c |
Signed-off-by: Jack Yu <[email protected]>
|
/ok to test a62ed14 |
…usly and OOM Signed-off-by: Jack Yu <[email protected]>
|
/ok to test 5bd69ed |
Signed-off-by: Jack Yu <[email protected]>
|
/ok to test 9fbadec |
Signed-off-by: Jack Yu <[email protected]>
|
/ok to test 2876b69 |
|
@maxjeblick, I think this PR is ready to merge. Changes from main is already merged to this branch after conflict resolution. Changes since my takeover:
|
Signed-off-by: Jack Yu <[email protected]>
Signed-off-by: Jack Yu <[email protected]>
|
/ok to test 6abef90 |
The test is failing for one sample (as you mentioned). I propose finding a sample index that works for all presses. |
Signed-off-by: Jack Yu <[email protected]>
Signed-off-by: Jack Yu <[email protected]>
|
/ok to test 2aedcc5 |
Signed-off-by: Jack Yu <[email protected]>
|
/ok to test defd68f |
Signed-off-by: Jack Yu <[email protected]>
|
/ok to test e4ae240 |
Signed-off-by: Jack Yu <[email protected]>
|
/ok to test 9073cf3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
PR description
This PR
make testwill only pass if all tests pass (i.e. we do not allow to skip tests)Fixes #131
Checklist
make test)make style, on errors try fix withmake format)git commit -smypress_press.pyis in thepressesdirectoryMyPressis in__init__.pyREADME.mdis updated with a 1 liner about the new press in the Available presses sectiondefault_presseslist intests/default_presses.py