Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@maxjeblick
Copy link
Collaborator

PR description

This PR

  • moves existing tests to gpu (if run on a GPU)
  • make test will only pass if all tests pass (i.e. we do not allow to skip tests)

Fixes #131

Checklist

  • Tests are working (make test)
  • Code is formatted correctly (make style, on errors try fix with make format)
  • Copyright header is included
  • All commits are signed-off using git commit -s
  • (new press) mypress_press.py is in the presses directory
  • (new press) MyPress is in __init__.py
  • (new press) README.md is updated with a 1 liner about the new press in the Available presses section
  • (new press) New press is in the default_presses list in tests/default_presses.py
  • (new press) A docstring is provided that follows the same structure as the existing ones

Signed-off-by: Maximilian Jeblick <[email protected]>
Signed-off-by: Max Jeblick <[email protected]>
Signed-off-by: Max Jeblick <[email protected]>
@copy-pr-bot
Copy link

copy-pr-bot bot commented Aug 27, 2025

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@alessiodevoto
Copy link
Contributor

/ok to test c6383f2

@maxjeblick
Copy link
Collaborator Author

/ok to test f83914e

@maxjeblick
Copy link
Collaborator Author

/ok to test fa3e9c0

@maxjeblick
Copy link
Collaborator Author

/ok to test f83914e

@copy-pr-bot
Copy link

copy-pr-bot bot commented Aug 27, 2025

/ok to test f83914e

@maxjeblick, there was an error processing your request: E2

See the following link for more information: https://docs.gha-runners.nvidia.com/cpr/e/2/

@maxjeblick
Copy link
Collaborator Author

/ok to test 59f3156

@maxjeblick
Copy link
Collaborator Author

/ok to test 9eaf5a7

Signed-off-by: Max Jeblick <[email protected]>
@maxjeblick
Copy link
Collaborator Author

/ok to test 92d6e0e

@maxjeblick
Copy link
Collaborator Author

/ok to test 4987ef9

Signed-off-by: Max Jeblick <[email protected]>
@maxjeblick
Copy link
Collaborator Author

/ok to test 7ad2049

Signed-off-by: Max Jeblick <[email protected]>
@maxjeblick
Copy link
Collaborator Author

/ok to test a58c28b

@maxjeblick
Copy link
Collaborator Author

Works now except for qfilter press

@Jack-Yu-815
Copy link
Collaborator

/ok to test df1b283

@Jack-Yu-815
Copy link
Collaborator

/ok to test 5bd4b6c

@Jack-Yu-815
Copy link
Collaborator

/ok to test a62ed14

@Jack-Yu-815
Copy link
Collaborator

/ok to test 5bd69ed

@Jack-Yu-815
Copy link
Collaborator

/ok to test 9fbadec

Signed-off-by: Jack Yu <[email protected]>
@Jack-Yu-815
Copy link
Collaborator

/ok to test 2876b69

@Jack-Yu-815
Copy link
Collaborator

@maxjeblick, I think this PR is ready to merge. Changes from main is already merged to this branch after conflict resolution.

Changes since my takeover:

  • a separate RULER test specifically for QFilterPress
  • allow RULER test's prep_answer to be wrong. Give a warning instead of AssertionError.
  • changing LLM fixture scope to "class", allowing GPU memory to be freed first before loading another LLM. This avoids OOM on the runner.
  • refactor some tests (that require large GPU memory for LLM) into test class, which enables the fixture scope "class"

@Jack-Yu-815
Copy link
Collaborator

/ok to test 6abef90

@maxjeblick
Copy link
Collaborator Author

tests/integration/test_ruler.py::TestRuler::test_ruler_is_correct[0-dynamic-press_dict0] FAILED [  3%]
FAILED tests/integration/test_ruler.py::TestRuler::test_ruler_is_correct[0-dynamic-press_dict0] - assert '9375710' in 'The special magic number for **fair-sprout** mentioned in the provided text is **937510**.\n\nWait — let\'s double-check.\n\nThe text says:\n\n> "One of the special magic numbers for fair-sprout'

The test is failing for one sample (as you mentioned). I propose finding a sample index that works for all presses.

@Jack-Yu-815
Copy link
Collaborator

/ok to test 2aedcc5

Signed-off-by: Jack Yu <[email protected]>
@Jack-Yu-815
Copy link
Collaborator

/ok to test defd68f

Signed-off-by: Jack Yu <[email protected]>
@Jack-Yu-815
Copy link
Collaborator

/ok to test e4ae240

@Jack-Yu-815
Copy link
Collaborator

/ok to test 9073cf3

Copy link
Collaborator

@Jack-Yu-815 Jack-Yu-815 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@maxjeblick maxjeblick merged commit d31a190 into main Oct 9, 2025
3 checks passed
@maxjeblick maxjeblick deleted the max/gpu_tests branch October 9, 2025 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update tests

4 participants