Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@acolwell
Copy link
Collaborator

@acolwell acolwell commented Jun 5, 2025

Thanks for submitting a pull request! Please provide enough information so that others can review your pull request. Additionally, make sure you've done all of these things:

PR Description

What type of PR is this? (Check one of the boxes below)

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Improvement (non-breaking change which does not add functionality nor fixes a bug but improves Natron in some way)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • My change requires a change to the documentation
    • I have updated the documentation accordingly

What does this pull request do?

GMIC.ofx now appears to depend on libngtcp2 DLLs. This change updates genDllVersions.sh to include these DLLs in the installer so the plugin can load properly.

Have you tested your changes (if applicable)? If so, how?

Yes. Verified the Windows Installer build successfully again

GMIC.ofx now appears to depend on libngtcp2 DLLs. This change
updates genDllVersions.sh to include these DLLs in the installer so
the plugin can load properly.
@acolwell acolwell requested a review from rodlie June 8, 2025 22:08
@acolwell acolwell merged commit a1c13cf into NatronGitHub:RB-2.6 Jun 8, 2025
3 checks passed
@acolwell acolwell deleted the fix_gmic_dlls branch June 8, 2025 22:30
@acolwell
Copy link
Collaborator Author

acolwell commented Jun 8, 2025

Thanks for the review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants