Thanks to visit codestin.com
Credit goes to github.com

Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: contributor-assistant/github-action
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: master
Choose a base ref
...
head repository: Necromos/cla-action
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: master
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 9 commits
  • 23 files changed
  • 1 contributor

Commits on Jun 19, 2020

  1. fix: fixed issue with GraphQL handling

    Plugin states that it works for issues and pull requests, unfortunately
    that's not the case. `getCommiters()` code only relates to pull_requests
    GitHub GraphQL information where issues response structure is different.
    
    Bound to: OCM-220
    Necromos committed Jun 19, 2020
    Configuration menu
    Copy the full SHA
    83396e7 View commit details
    Browse the repository at this point in the history
  2. fix: changed casing of path-To-cladocument to path-to-cla-document

    As original repository have this "weird" approach to casing for this
    parameter this PR introduces a change for it to be more intuitive,
    convention keeping and easier to read.
    
    Bound to: OCM-220
    Necromos committed Jun 19, 2020
    Configuration menu
    Copy the full SHA
    5ebfb92 View commit details
    Browse the repository at this point in the history
  3. feat: cross-repository saving

    Introduces cross-repository saving functionality
      * introduced `persistance-repository` as optional parameter
      * introduced `PERSISTANCE_GITHUB_TOKEN` as optional ENV variable
      * introduced `repoName` to saved CLA record for clarity
      * code should use persistance github token and save CLA acceptance
        into `persistance-repository`
      * aded README related to changes
    
    Bound to: OCM-220
    Necromos committed Jun 19, 2020
    Configuration menu
    Copy the full SHA
    003cae6 View commit details
    Browse the repository at this point in the history

Commits on Jun 22, 2020

  1. chore: adding cla check workflow

    As all users making contributions into Ockam repositories needs to sign
    the CLA beforehand this workflow will give prompt them for approval and
    manage the persistence.
    Necromos committed Jun 22, 2020
    Configuration menu
    Copy the full SHA
    f7d637f View commit details
    Browse the repository at this point in the history
  2. fix: incorrect pull request comment handling

    It occurs that Github names pull request comment event as issue_comment which
    resulted in running incorrect graphql handler.
    Necromos committed Jun 22, 2020
    Configuration menu
    Copy the full SHA
    1267065 View commit details
    Browse the repository at this point in the history

Commits on Jun 23, 2020

  1. chore: adding action.yml inputs definitions

    Adding missing definitions for action inputs
    Necromos authored and mrinalwadhwa committed Jun 23, 2020
    Configuration menu
    Copy the full SHA
    c74f4dc View commit details
    Browse the repository at this point in the history

Commits on Jul 15, 2020

  1. feat: adding cross-pr handling functionality

    These changes introduces possibility to re-run workflows from within
    master-run action handling. You should be able to: rerun recently
    failed workflow, correctly pass workflow as success in case of fork PR
    opened with CLA signed (no message will be post due to token read
    limitation), allow to read CLA document cross repository without auth
    token (as github token is limited to specific repo for fork PR and
    persistance token does not exist)
    Necromos committed Jul 15, 2020
    Configuration menu
    Copy the full SHA
    4a82b71 View commit details
    Browse the repository at this point in the history

Commits on Jul 21, 2020

  1. fix: incorrect logic for workflow rerun

    Fixing the edge case where re-run would create additional re-run as
    conclusion was reacting to everything else than success which was
    incorrect.
    Necromos committed Jul 21, 2020
    Configuration menu
    Copy the full SHA
    076ce74 View commit details
    Browse the repository at this point in the history
  2. chore: updated cla workflow to match new changes

    This PR introduces additional changes to match how currently CLA
    workflow works. It should react on issues and PRs correctly while also
    give better end-flow.
    Necromos authored and mrinalwadhwa committed Jul 21, 2020
    Configuration menu
    Copy the full SHA
    f61548a View commit details
    Browse the repository at this point in the history
Loading