-
-
Notifications
You must be signed in to change notification settings - Fork 109
Comparing changes
Open a pull request
base repository: contributor-assistant/github-action
base: master
head repository: Necromos/cla-action
compare: master
- 9 commits
- 23 files changed
- 1 contributor
Commits on Jun 19, 2020
-
fix: fixed issue with GraphQL handling
Plugin states that it works for issues and pull requests, unfortunately that's not the case. `getCommiters()` code only relates to pull_requests GitHub GraphQL information where issues response structure is different. Bound to: OCM-220
Configuration menu - View commit details
-
Copy full SHA for 83396e7 - Browse repository at this point
Copy the full SHA 83396e7View commit details -
fix: changed casing of
path-To-cladocumenttopath-to-cla-documentAs original repository have this "weird" approach to casing for this parameter this PR introduces a change for it to be more intuitive, convention keeping and easier to read. Bound to: OCM-220
Configuration menu - View commit details
-
Copy full SHA for 5ebfb92 - Browse repository at this point
Copy the full SHA 5ebfb92View commit details -
Introduces cross-repository saving functionality * introduced `persistance-repository` as optional parameter * introduced `PERSISTANCE_GITHUB_TOKEN` as optional ENV variable * introduced `repoName` to saved CLA record for clarity * code should use persistance github token and save CLA acceptance into `persistance-repository` * aded README related to changes Bound to: OCM-220Configuration menu - View commit details
-
Copy full SHA for 003cae6 - Browse repository at this point
Copy the full SHA 003cae6View commit details
Commits on Jun 22, 2020
-
chore: adding cla check workflow
As all users making contributions into Ockam repositories needs to sign the CLA beforehand this workflow will give prompt them for approval and manage the persistence.
Configuration menu - View commit details
-
Copy full SHA for f7d637f - Browse repository at this point
Copy the full SHA f7d637fView commit details -
fix: incorrect pull request comment handling
It occurs that Github names pull request comment event as issue_comment which resulted in running incorrect graphql handler.
Configuration menu - View commit details
-
Copy full SHA for 1267065 - Browse repository at this point
Copy the full SHA 1267065View commit details
Commits on Jun 23, 2020
-
chore: adding action.yml inputs definitions
Adding missing definitions for action inputs
Configuration menu - View commit details
-
Copy full SHA for c74f4dc - Browse repository at this point
Copy the full SHA c74f4dcView commit details
Commits on Jul 15, 2020
-
feat: adding cross-pr handling functionality
These changes introduces possibility to re-run workflows from within master-run action handling. You should be able to: rerun recently failed workflow, correctly pass workflow as success in case of fork PR opened with CLA signed (no message will be post due to token read limitation), allow to read CLA document cross repository without auth token (as github token is limited to specific repo for fork PR and persistance token does not exist)
Configuration menu - View commit details
-
Copy full SHA for 4a82b71 - Browse repository at this point
Copy the full SHA 4a82b71View commit details
Commits on Jul 21, 2020
-
fix: incorrect logic for workflow rerun
Fixing the edge case where re-run would create additional re-run as conclusion was reacting to everything else than success which was incorrect.
Configuration menu - View commit details
-
Copy full SHA for 076ce74 - Browse repository at this point
Copy the full SHA 076ce74View commit details -
chore: updated cla workflow to match new changes
This PR introduces additional changes to match how currently CLA workflow works. It should react on issues and PRs correctly while also give better end-flow.
Configuration menu - View commit details
-
Copy full SHA for f61548a - Browse repository at this point
Copy the full SHA f61548aView commit details
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff master...master