Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Question: Is there a place for these commands? #47

@jrm16020

Description

@jrm16020

I'm sorry if this isn't the best place for this kind of conversation but I'm not sure where else to start it.

The company that I work for is a heavy user of AWS. For that reason I'm able to make some assumptions about where my hubcommander bot would be running and the resources that it would have available to it. I wanted to start learning Python and extend Hubcommander so I've added several commands, commands that I've put in a separate class to prevent missing out on other work that's merged here.

I'm waiting for #40 to be merged so I can refactor my code a bit. That said, when I've been able to do that I'm curious if there's a place for more opinionated commands/functionality like the below, maybe in a separate contrib directory with additional instructions on how to make use of them?

  • get_credentials method that uses EC2 SSM parameter store for retrieving credentials
  • !CreatePR to do the obvious
  • !AddReviewerGroup, !RemoveReviewerGroup, !ListReviewerGroups, !DescribeReviewerGroup, !AddToReviewerGroup, !RemoveFromReviewerGroup and finally, !AddReviewersToPR each would make use of SSM parameter store in some form. The goal is to use hubcommander for creating a pull request and allowing our developers to add reviewers to their PR by group without having to provide them admin access to the repo.
  • !CheckUsername will return the user's real name if they're still a member of your organization. Helpful for performing cleanup on a reviewer group in case an employee leaves the company.
  • !GetPRInfo returns the HTTP URL of a pull request
  • !ToggleAdminBranchProtection to do the obvious.

I wanted to ask before opening a PR. Thank you for any input you can offer!

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions