-
Notifications
You must be signed in to change notification settings - Fork 91
Open
Description
After an error in listener.Accept() remote object can be nil.
Line 122 in d3db570
| remote, err := listener.Accept() |
Calling
remote.Close() in this line causes a panic.Line 125 in d3db570
| remote.Close() |
We noticed this behaviour because this error Error accepting connection from remote: accept tcp [::]:11211: accept4: too many open files causes our implementation to panic.
Since the wanted behavior is to continue the listener.Accept() loop in case of error, we should wrap this particular remote.Close() call with an if remote != nil statement
Metadata
Metadata
Assignees
Labels
No labels