Hi @sbejaoui,
some modules you are maintaining are being modified, check this out!

I have pushed a new version.
The first approach was a bit naive, it was based on the field recurrence_number, which is not the actual number of times the line will be invoiced.
Thus, I add a new field recurring_invoicing_number for this.

But why do you need an extra multiplier and the quantity is not enough?

But why do you need an extra multiplier and the quantity is not enough?

Let's say you sell a subscription over 3 years, invoiced every quarter with a unit price of 100€.

Prior to f50e15d, you would have:

• price_unit = 100.0
• product_uom_qty = 12 (there are 12 quarters in 3 years)

Thus the subtotal of the line would be 1200€ (price_unit * product_uom_qty).
It makes sense, in total the customer will have to pay 1200€ for this subscription.

After f50e15d, you would have:

• price_unit = 100.0
• product_uom_qty = 1
• recurring_interval = 1
• recurring_rule_type = "quarterly"

Without this PR, the subtotal of the line would be 100€ (price_unit * product_uom_qty), which is wrong.
With this PR, we have:

• recurring_invoicing_number = 12 (there are 12 quarters in 3 years) / 1 (recurring_interval)

And the subtotal of the line would be 1200€: 100 (price_unit) * 12 (recurring_invoicing_number) * 1 (product_uom_qty)

The original intention of the system is that you put on the sale.order.line the "setup" price, and then, when confirmed, the contract is created for the recurring "maintenance" price. What you are telling is that you put in the quotation the full price of the whole "maintenance" price period. That use case sounds very weird, and I think it's over-complicating this module, so it should be handled on extra modules on top.

The original intention of the system is that you put on the sale.order.line the "setup" price, and then, when confirmed, the contract is created for the recurring "maintenance" price. What you are telling is that you put in the quotation the full price of the whole "maintenance" price period. That use case sounds very weird, and I think it's over-complicating this module, so it should be handled on extra modules on top.

The use case is the sale of subscriptions.
Recurrences are not maintenance cost, this is a service that the customer pays every month for X years.

I understand that this module can solve different use cases, therefore I have added this as a new option in a new module.