Use _delta custom vocabularies instead of gcpt tables
#37
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
I looked through both commits, everything looks good. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An improved workflow has been implemented for mapping the MIMIC custom vocabularies. This work is done under this repository: https://github.com/TuftsCTSI/CVB/tree/main.
This PR updates the vocabulary refresh code to make use of these custom vocabulary
_deltatables instead of thegcpttables which were used in v1.0.0 and prior versions of this repository. Additional_deltatables beyond those in the TuftsCTSI can be merged with the Athena tables, as needed.This is the first PR since marking v1.0.0 of this repository. There will be at least 2 more PRs that should be completed prior to merging into the main branch. This PR will merge into the
devbranch (which started from v1.0.0) in meantime. Once all of the code is updated to run the full ETL, we will mergedevintomain.