Fix alberta for dune 2.9 #4028
Merged
Fix alberta for dune 2.9 #4028
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Default is now 3 as in DUNE but user can request more via variable ALBERTA_MAX_WORLD_DIM.
If OPM modules are used as DUNE modules then CMake otherwise
complains about missing targets:
```
CMake Error at /usr/lib/x86_64-linux-gnu/cmake/dune-grid/dune-grid-targets.cmake:78 (set_target_properties):
The link interface of target "dunealbertagrid1d" contains:
PkgConfig::Alberta1d
but the target was not found. Possible reasons include:
* There is a typo in the target name.
* A find_package call is missing for an IMPORTED target.
* An ALIAS target is missing.
```
|
jenkins build this please |
|
Thanks. Sorry, I often forget the upstreaming.... 😳 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dune 2.9 expects Alberta targets to available as PkgConfig::Albertaxd.
These are patches done by @blattms for debian packaging. My contribution is exactly opening the PR for getting them into the main repo.
Should be in the release since dune 2.9 will be what the release is based on and users should be able to build the sources on their own, not just use the binary packages.