Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Prevent tautological-compare warnings for format.h with gcc 14.2.0 #4574

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 28, 2025
Merged

Prevent tautological-compare warnings for format.h with gcc 14.2.0 #4574

merged 1 commit into from
Apr 28, 2025

Conversation

@hakonhagland
Copy link
Contributor

With gcc 14.2.0 (Ubuntu 24.10), I get a lot of warnings like this

/home/hakon/test/opm/opm/opm-simulators/build/_deps/fmt-src/include/fmt/ranges.h:215:59: warning: self-comparison always evaluates to true [-Wtautological-compare]
  215 |                                integer_sequence<bool, (Is == Is)...>);
      |                                                        ~~~^~~~~

when compiling. By adding the SYSTEM option to include_directories() for the format library, cmake will skip the warnings for the format library headers. See also: fmtlib/fmt#3830

@hakonhagland
Prevent warnings for format.h with gcc 14.2.0
f70cb32 
Prevent -Wtautological-compare warnings for format library with gcc 14.2
akva2
akva2 approved these changes Apr 28, 2025
View reviewed changes
Copy link
Member

@akva2 akva2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i'd just install libfmt-dev instead of relying on the autodownload, but sure, this is fine.

@akva2 akva2 merged commit bae7ff6 into OPM:master Apr 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@akva2 akva2 akva2 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@hakonhagland @akva2