RstState: add check for undefined DRSDT in load_oil_vaporization #4655
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
jenkins build this please |
bska
approved these changes
Jul 3, 2025
Member
bska
left a comment
There was a problem hiding this comment.
This looks good to me and fixes the problem. At some point we should do something about those magic constants (i.e., 1.0e+20) that are scattered about this part of the code, but for now I'm happy with the interim solution.
I'll merge into master.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using restart, the DRSDT ended up being active for a simulation that did not use DRSDT in the first place. This matters for functions like
recycleFirstIterationStorage()but I am not sure if it had any real consequences as of now.Fixing this is required for OPM/opm-simulators#6357 to work.
I added a check which checks if the DRSDT value was defined in the state and skips updating the oilvap object if this is the case, which resolves this problem.