import VoigtArray and SymmTensor from opm-simulators #4661
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
jenkins build this opm-simulators=6373 please |
|
jenkins build this opm-simulators=6373 please |
|
jenkins build this opm-simulators=6373 please |
bska
approved these changes
Jul 16, 2025
|
For what it's worth, I just ran into a local build failure following this PR. Both Is this the point where we finally need to make OPM-Common depend on dune-common? |
|
sorry forgot about that, should be taken care of in #4662 no need to change policies, we'll just not build the code as we do for some other stuffs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These fundamental types will also be useful in the state classes in this repo so let's move them up the chain.