Make GSATPROD Create New Groups if Needed #4689
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
I'm creating this PR in draft mode for two reasons
I will keep the PR in a draft state until such time as it is ready for review and merging. |
c478c29 to
5dee650
Compare
In particular this means that
GSATPROD
SAT 12345.67 89101.1 121314.15 /
/
will create the group 'SAT' if it does not already exist at the
point when the GSATPROD keyword is entered. Groups created in this
way will be parented directly to the FIELD group.
5dee650 to
f2ba587
Compare
Member
Author
Member
Author
|
jenkins build this please |
akva2
approved these changes
Aug 22, 2025
Member
akva2
left a comment
There was a problem hiding this comment.
Looks good and seems to do what was announced
Member
Author
|
PR approved and build check is green. I'll merge into master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In particular this means that
will create the group
SATif it does not already exist at the point when theGSATPRODkeyword is entered. Groups created in this way will be parented directly to theFIELDgroup.