add 'download as zip' button to sessions #4693
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harshit-soora
pushed a commit
to harshit-soora/ondemand
that referenced
this pull request
Oct 31, 2025
Add 'download as zip' button to sessions to completed sessions as a utility for support staff.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1269. Adds a button with a download link to the session directory that is only visible if the user is configured to download and the session has been completed. This should eliminate the risk of sensitive session info being present, but if we do want to exclude something from the download in the future that will be significant changes beyond these. It places the download button next to the 'Submit support ticket' link, which has been formatted as a button to match.
There was no clear method to create a download link, but from investigating the download urls provided by the files app, adding
?download=1did the job. Elsewhere in the code I have seendownload=${Date.now().toString()}but not sure what the date is used for and setting it to 1 did not affect my ability to download. Also added a localization item for the 'Download as zip' text.