Provide view override for batch connect sub apps #4694
Conversation
|
Can you give me an example of why you'd need a different view for the same underlying application? |
|
I started out modifying stiff in /var/www/ood and making custom copies of the sys/bc_desktop app. It wasn't great though as stuff was split between /etc/ood and /var/www/ood, and some of the changes in /var/www/ood would get clobbered on updates. Eventually I discovered almost all my customization could be handled as sub apps in /etc/ood/apps. The one thing I couldn't fit into this was anything that would launch a web interface (e.g., jupyterlab) as that required a custom view to make the connection. I know these can be handled by creating a whole separate apps for each one, but it seemed a lot cleaner to just make them all sub apps of one |
I guess I'm still just wondering why you'd need a 2nd/different view.html.erb for Jupyter. Doesn't it connect in the same way for all applications? |
|
Ah. Yes. As long as you stick it just Jupyter you are okay. I was working on rolling out a bunch of different web interfaces though (e.g., jupyter, rstudio, zellij, etc.) all as sub apps of a primary batch connect app. |
|
Oh OK! Just curious more than anything in case we come back to recall why this change was made. |
|
No problem. I am still pretty new to OOD, so it is entirely possible that I am doing things in silly ways. 😸 |
|
I've tested this out and it works as expected. Though I think I would like to see that one update made to be more inline with idiomatic ruby. |
Adding a view override to makes it possible to handle custom connections as part of a sub app instead of having to role an entirely new interactive app just to provide a view.html.erb. It follows the same style as the submit script override.
|
Sounds good. Just force pushed an update with the revision. Thanks for checking this out. 👍 |
Thank you! I'll try to get it merged today. |
|
Thanks! |
Adding a view override to makes it possible to handle custom connections as part of a sub app instead of having to role an entirely new interactive app just to provide a view.html.erb. It follows the same style as the submit script override.
Adding a view override to makes it possible to handle custom connections as part of a sub app instead of having to role an entirely new interactive app just to provide a view.html.erb.
It follows the same style as the submit script override.
I can do up some documentation and do pull request for that too if this is deemed suitable for merging.