Fix unhandled exception with broken symlink in directory #4735
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dereferencing a symlink with path.realpath raises an exception if it the symlink is broken, but the exception is never rescued, causing a 0 byte zip.
du exists with status 1 if it encounters any error, e.g. a broken symlink. Example output seems to have been done without the -s flag.
Contributor
Author
|
Updated the implementation to not break the existing tests and added a new tests specifically for the broken symlinks, although it is only for the |
Contributor
|
Thanks for the fix! |
harshit-soora
pushed a commit
to harshit-soora/ondemand
that referenced
this pull request
Oct 31, 2025
* Fix unhandled exception with broken symlink in zip Dereferencing a symlink with path.realpath raises an exception if it the symlink is broken, but the exception is never rescued, causing a 0 byte zip. * Fix du exit code check du exists with status 1 if it encounters any error, e.g. a broken symlink. Example output seems to have been done without the -s flag.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4714.
Dereferencing a symlink with
path.realpathraises an exception if it the symlink is broken, but the exception is never rescued, causing a 0 byte zip.However, #4715 introduced
-L(--dereference), which will attempt to dereference all symlinks, which exits with exit code 1 if it encounters broken symlinks. This fixes the error handling logic fordu, although I'm not 100% sure if there are cases whereduexits with 1 and it is actually an error we do not want to attempt to parse the result of.