Sentinel - announce-ip <hostname> when resolve & announce are set #95
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b79379a to
94627b5
Compare
shubham-cmyk
approved these changes
Mar 10, 2025
|
@drivebyer Please review this |
|
lgtm. BTW, @nicogigi92 please add related logic to https://github.com/OT-CONTAINER-KIT/redis-operator/blob/master/pkg/agent/bootstrap/generate_sentinel_config.go. |
Signed-off-by: Nicolas Girard <[email protected]>
94627b5 to
f541c5f
Compare
drivebyer
added a commit
to OT-CONTAINER-KIT/redis-operator
that referenced
this pull request
Mar 11, 2025
) Relate to [95](OT-CONTAINER-KIT/redis#95) in image repository
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As explained in this comment and in the official Redis documentation, to avoid mixing IPs and hostnames, Sentinel must announce its hostname instead of its IP using the
announce-ipconfiguration.