Fix issue where linking to tlmgrapher doesn't respect set timezone #2270
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2270 +/- ##
=======================================
Coverage 80.00% 80.00%
=======================================
Files 641 641
Lines 47966 47943 -23
Branches 744 738 -6
=======================================
- Hits 38374 38359 -15
+ Misses 9510 9502 -8
Partials 82 82
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
| if (response) { | ||
| this.timeZone = response | ||
| } | ||
| this.$nextTick(() => { |
There was a problem hiding this comment.
Is this nextTick necessary?
There was a problem hiding this comment.
Yes, so that the v-if can update and get the graphs created so they can be referenced with this.$refs in code that's called by setup()
There was a problem hiding this comment.
This is immediately evident when you right click to graph. Makes sense although I don't like waiting for an API request to draw the entire graph ... although I guess this is just the graph itself and the rest of the UI renders. Wonder if we could write this out to local storage and use that throughout?
Yeah, the API call is necessary with the way Graph.vue is written at the moment. It should ultimately be in a store like Pinia (not directly on window.localStorage), which I was discussing with Clay on Slack earlier |
No description provided.