Faiza #21
Open
Faiza #21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CheezItMan
reviewed
Oct 4, 2019
CheezItMan
left a comment
There was a problem hiding this comment.
Overall not bad, but there are small issues. Take a look at my comments and see if they make sense. Let me know any questions you have.
| swap(0, @store.length - 1) | ||
| removed_node = @store.pop | ||
| heap_down(0) | ||
| return removed_node.value |
There was a problem hiding this comment.
Getting a NoMethodError here in the "can sort a 5-element array" test.
| def heapsort(list) | ||
| return list if list.empty? || list.length == 1 | ||
|
|
||
| minHeap = MinHeap.new() |
There was a problem hiding this comment.
Just a note that coding style for minHeap should be min_heap
Comment on lines
+55
to
+57
| if @store.empty? | ||
| return | ||
| end |
There was a problem hiding this comment.
You're returning nil if @store.empty? I would instead return @store.empty?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Heaps Practice
Congratulations! You're submitting your assignment!
Comprehension Questions
heap_up&heap_downmethods useful? Why?