feat(Build): add getMissingLocalDependencies function

AngelMunoz · AngelMunoz · commit c5962d3cb28a · 2025-07-21T17:28:16.000-06:00
- Implemented a function to check for missing local dependencies in the import map.
- Returns a list of missing package@version strings.
- Integrated pre-build check for undeclared dependencies in the build process.
diff --git a/src/Perla/Build.fs b/src/Perla/Build.fs
@@ -228,6 +228,85 @@ module Build =
 
     cssFiles, jsFiles
 
+  /// Checks for missing local dependencies referenced in the import map (from both imports and scopes).
+  /// Returns a list of missing package@version strings.
+  let getMissingLocalDependencies
+    (config: PerlaConfig)
+    (importMap: Perla.PkgManager.ImportMap)
+    : string list =
+    if not config.useLocalPkgs then
+      []
+    else
+      let tryExtractPkgVer(path: string) =
+        let marker = "/node_modules/.perla/"
+        let idx = path.IndexOf(marker)
+
+        if idx >= 0 then
+          let rest = path.Substring(idx + marker.Length)
+
+          let parts =
+            rest.Split([| '/' |], System.StringSplitOptions.RemoveEmptyEntries)
+
+          if parts.Length = 0 then
+            None
+          elif parts.[0].StartsWith("@") && parts.Length >= 2 then
+            // Scoped package: join first two segments
+            Some(parts.[0] + "/" + parts.[1])
+          else
+            // Unscoped package: just the first segment
+            Some(parts.[0])
+        else
+          None
+
+      let allPkgVers =
+        importMap.imports.Values
+        |> Seq.append(
+          importMap.scopes |> Seq.collect(fun kv -> kv.Value.Values)
+        )
+        |> Seq.choose tryExtractPkgVer
+        |> Seq.distinct
+        |> Seq.toList
+
+      let cwd = System.IO.Directory.GetCurrentDirectory()
+
+      let getTopLevelNodeModulesPath (cwd: string) (pkgVer: string) =
+        if pkgVer.StartsWith("@") then
+          // Scoped: @scope/name@version
+          let atIdx = pkgVer.IndexOf("@", 1) // skip first char
+
+          if atIdx > 0 then
+            let scope = pkgVer.Substring(0, atIdx)
+            let nameAndVersion = pkgVer.Substring(atIdx + 1)
+            let nameEndIdx = nameAndVersion.IndexOf("@")
+
+            if nameEndIdx > 0 then
+              let name = nameAndVersion.Substring(0, nameEndIdx)
+              System.IO.Path.Combine(cwd, "node_modules", scope, name)
+            else
+              System.IO.Path.Combine(cwd, "node_modules", scope)
+          else
+            System.IO.Path.Combine(cwd, "node_modules", pkgVer)
+        else
+          // Unscoped: name@version
+          let nameEndIdx = pkgVer.IndexOf("@")
+
+          let name =
+            if nameEndIdx > 0 then
+              pkgVer.Substring(0, nameEndIdx)
+            else
+              pkgVer
+
+          System.IO.Path.Combine(cwd, "node_modules", name)
+
+      allPkgVers
+      |> List.filter(fun pkgVer ->
+        let topLevelPath = getTopLevelNodeModulesPath cwd pkgVer
+
+        not(
+          System.IO.Directory.Exists(topLevelPath)
+          || System.IO.File.Exists(topLevelPath)
+        ))
+
 module BuildService =
   let Create(args: BuildServiceArgs) : BuildService =
     { new BuildService with
diff --git a/src/Perla/Build.fsi b/src/Perla/Build.fsi
@@ -16,6 +16,11 @@ type BuildOptions = { enablePreview: bool }
 
 [<RequireQualifiedAccess>]
 module Build =
+  /// Checks for missing local dependencies referenced in the import map (from both imports and scopes).
+  /// Returns a list of missing package@version strings.
+  val getMissingLocalDependencies:
+    config: PerlaConfig -> importMap: Perla.PkgManager.ImportMap -> string list
+
   val EnsureBody: IHtmlDocument -> AngleSharp.Dom.IElement
   val EnsureHead: IHtmlDocument -> AngleSharp.Dom.IElement
 
diff --git a/src/Perla/Handlers.fs b/src/Perla/Handlers.fs
@@ -600,72 +600,100 @@ module Handlers =
 
     let resolutionA = ImportMaps.resolveForBuildA config importMapA
 
+    let missing =
+      adaptive {
+        let! config = config
+        let! map = importMapA
+        return Build.getMissingLocalDependencies config map
+      }
+      |> AVal.force
+
     let {
           importMap = map
           externals = externals
         } =
       resolutionA |> AVal.force
 
-    let cssPaths, jsBundleEntrypoints, jsStandalonePaths =
-      Build.EntryPoints document
-
-    // Step 9: Run esbuild or move/copy output
-    let! esbuildOutput =
-      container.BuildService.RunEsbuild(
-        config,
-        tempDir,
-        cssPaths,
-        jsBundleEntrypoints,
-        externals |> Seq.map UMX.untag |> Seq.toList
+    // Pre-build check for missing local dependencies
+    if (config |> AVal.force).useLocalPkgs && missing.Length > 0 then
+      container.Logger.LogError(
+        "We've found undeclared dependencies: {pkgs}.",
+        String.concat ", " missing
       )
 
-    container.BuildService.MoveOrCopyOutput(
-      config,
-      tempDir,
-      esbuildOutput.outputDir
-    )
+      container.Logger.LogError
+        "Your project is currently implicitly using these undeclared dependencies, to proceed with the build add them to your dependencies."
 
-    // Step 10: Write index.html
-    let jsPaths = seq {
-      yield! jsStandalonePaths
-      yield! jsBundleEntrypoints
-    }
+      container.Logger.LogError(
+        "{cmd}",
+        "perla add " + String.concat " " missing
+      )
 
-    do!
-      container.BuildService.WriteIndex(
+      return 1
+    else
+      let cssPaths, jsBundleEntrypoints, jsStandalonePaths =
+        Build.EntryPoints document
+
+      // Step 9: Run esbuild or move/copy output
+      let! esbuildOutput =
+        container.BuildService.RunEsbuild(
+          config,
+          tempDir,
+          cssPaths,
+          jsBundleEntrypoints,
+          externals |> Seq.map UMX.untag |> Seq.toList
+        )
+
+      container.BuildService.MoveOrCopyOutput(
         config,
-        document,
-        map,
-        jsPaths,
-        cssPaths,
-        esbuildOutput.cssFiles
+        tempDir,
+        esbuildOutput.outputDir
       )
 
-    // // cleanup temporary directory
-    try
-      Directory.Delete(UMX.untag ".tmp/perla", true) |> ignore
-    with ex ->
-      container.Logger.LogWarning(
-        "Failed to delete temporary directory {dir}: {error}",
-        UMX.untag ".tmp/perla",
-        ex.Message
-      )
+      // Step 10: Write index.html
+      let jsPaths = seq {
+        yield! jsStandalonePaths
+        yield! jsBundleEntrypoints
+      }
 
-    // Step 11: Start preview server if requested
-    if options.enablePreview then
-      container.Logger.LogInformation "Starting a preview server for the build"
+      do!
+        container.BuildService.WriteIndex(
+          config,
+          document,
+          map,
+          jsPaths,
+          cssPaths,
+          esbuildOutput.cssFiles
+        )
 
-      SuaveServer.startStaticServer
-        {
-          Logger = container.Logger
-          VirtualFileSystem = container.VirtualFileSystem
-          Config = config
-          FsManager = container.FsManager
-          FileChangedEvents = container.VirtualFileSystem.FileChanges
-        }
-        token
+      // // cleanup temporary directory
+      try
+        Directory.Delete(UMX.untag ".tmp/perla", true) |> ignore
+      with ex ->
+        container.Logger.LogWarning(
+          "Failed to delete temporary directory {dir}: {error}",
+          UMX.untag ".tmp/perla",
+          ex.Message
+        )
 
-    return 0
+      // Step 11: Start preview server if requested
+      if options.enablePreview then
+        container.Logger.LogInformation
+          "Starting a preview server for the build"
+
+        SuaveServer.startStaticServer
+          {
+            Logger = container.Logger
+            VirtualFileSystem = container.VirtualFileSystem
+            Config = config
+            FsManager = container.FsManager
+            FileChangedEvents = container.VirtualFileSystem.FileChanges
+          }
+          token
+
+        return 0
+      else
+        return 0
   }
 
   let runServe (container: AppContainer) (options: ServeOptions) = cancellableTask {
@@ -1031,7 +1059,10 @@ module Handlers =
         "Generating Import Map...",
         pkgManager.Install(
           installSet,
-          [ DefaultProvider provider ],
+          [
+            DefaultProvider provider
+            Env(set [ ExportCondition.Browser; ExportCondition.Module ])
+          ],
           cancellationToken = token
         )
       )
@@ -1064,7 +1095,7 @@ module Handlers =
           "Downloading Sources...",
           pkgManager.GoOffline(
             installResponse.map,
-            [ Provider config.provider ],
+            [ Provider config.provider; Exclude(set [ Unused ]) ],
             token
           )
         )
@@ -1165,7 +1196,10 @@ module Handlers =
           "Regenerating import map with remaining packages...",
           container.PkgManager.Install(
             remainingPackages,
-            [ DefaultProvider provider ],
+            [
+              DefaultProvider provider
+              Env(set [ ExportCondition.Browser; ExportCondition.Module ])
+            ],
             token
           )
         )
@@ -1184,7 +1218,7 @@ module Handlers =
             "Consolidating local packages...",
             container.PkgManager.GoOffline(
               newMapResponse.map,
-              [ Provider config.provider ],
+              [ Provider config.provider; Exclude(set [ Unused ]) ],
               token
             )
           )
