Update CommandList layout #117
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add command_category property to define the command category it belongs to
An script that handles the creation and selection of defined commands.
Add `disable` and `enable` methods to notify the editor and all childs that editor was enabled or disabled. Those methods are called on very specific scenarios and can be or not related to editing of a collection. Add `EditorConstants` (constants.gd) to keep track of editor constants that are related to editor but used by other non main editor related scripts.
Renames `command_list_button_pressed` to `command_button_pressed_callback` to make it a bit more specific of what command list needs. Changes argument of Editor `_command_list_button_pressed` from `Script` to `Command` , making easier the creation of commands from other commands (that will probably use more ram due keeping the resources always loaded but we'll see).
Update command list icon even when its disabled. Listen to DISABLED and ENABLED editor notifications to disable or enable command buttons.
AnidemDex
commented
Jan 21, 2024
There was a problem hiding this comment.
This file is supposed to be a file moved, no idea why it added it as a new file 🤔
Add a method to get ProjectSetting custom commands
Add custom commands into the list Update the way commands are displayed, sorting them after being added.
Crystalwarrior
approved these changes
Jan 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates
EditorCommandList(yeah, it has a name now) layout, adding collapsible categories.The category name definition is on
Command.command_categoryproperty (and_get_categoryaswell, since is supposed to be defined in the command and not in the file that command serializes).fix #108