Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@mtsokol
Copy link
Collaborator

@mtsokol mtsokol commented Feb 7, 2022

This PR adds support and CI stage for mypy.

Sequential PR: Need to merge #317 first.

Copy link
Member

@j-ittner j-ittner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great progress! Please see a few comments and questions, thanks!

@mtsokol mtsokol changed the title BUILD: support for mypy and drop Python 3.6 BUILD: support for mypy Feb 24, 2022
@j-ittner j-ittner changed the title BUILD: support for mypy BUILD: add support for mypy Mar 4, 2022
# Conflicts:
#	src/facet/data/partition/_partition.py
#	src/facet/inspection/_inspection.py
#	src/facet/inspection/_shap.py
#	src/facet/inspection/_shap_projection.py
@j-ittner j-ittner self-requested a review March 4, 2022 17:18
@j-ittner j-ittner merged commit 0cd01d0 into 2.0.x Mar 7, 2022
@j-ittner j-ittner deleted the build/add_support_for_mypy branch March 7, 2022 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

build Related to the test & build pipeline

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants