ci: Fix workflow definition for gherkin update and add actionlint #304
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@carlos-granados apologies for another iteration on this - I think this will work now. Certainly the action looks like it did what it was meant to this morning up until it failed on the empty value at the final step. |
On any pull request or push to master that modifies our actions workflows, use actionlint to check for problems in the workflow files.
So we can troubleshoot / iterate faster than waiting for the daily cron, and to make it easier to catch up multiple versions if we fall behind.
7b89d91 to
3e531ae
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #304 +/- ##
=========================================
Coverage 95.48% 95.48%
Complexity 598 598
=========================================
Files 35 35
Lines 1796 1796
=========================================
Hits 1715 1715
Misses 81 81
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
carlos-granados
approved these changes
Apr 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Annoyingly, I had another typo / oversight in the actions file (incorrect references to the outputs of a step) which caused the run to fail this morning https://github.com/Behat/Gherkin/actions/runs/14749065681/job/41402076670
This PR fixes that, and also introduces a new action to run actionlint on all our workflow files if they're changed. That would have caught this mistake, as proved in this build on my fork.
Additionally, I've added a manual workflow_dispatch trigger to the gherkin update to make it easier for us to troubleshoot this action in future without having to wait for the daily cron.