This repository was archived by the owner on Aug 29, 2023. It is now read-only.
xcube version upgrade to 0.9.1 and xcube-cci 0.9.0 #1018
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hat arose from that change: * `TYPE_SPECIFIER_CUBE` replaced with `DATASET_TYPE` * `get_type_specifiers_for_data` replaced with `get_data_types_for_data` * Changed xcube `directory` configurations to `file`. * Changed Dockerfile. Is now completely based on quay.io/bcdev/xcube.
…ng this test fixed test test_ index. There were slight differences between expected and region. - Combined test and conda build workflows as the must run in sequence not in parallel. Docker shall only build after a successful unittest run. - Removed ignoring json validation deprecation notice in test_main as the issue causing this message has been resolved in xcube 0.9.1
- Removed truediv from data_frame.query call. Deprecated due to change in Python3 - Renamed usages of `np.float` to just `float` as `np.float` is deprecated - Ensured that variables re_year, first_months and first_days in aggregate are initialized - Increased xcube version to 0.9.1 - Removed pinning of jsonschema. Issue solved in xcube 0.9.1
forman
suggested changes
Nov 4, 2021
Co-authored-by: Norman Fomferra <[email protected]>
Co-authored-by: Norman Fomferra <[email protected]>
TonioF
suggested changes
Nov 4, 2021
Contributor
TonioF
left a comment
There was a problem hiding this comment.
See my comments. Also, 'test_custom_region' in test_index.py fails on my local machine. I'd like to wait to see whether it works on Appveyor.
| username: ${{ secrets.QUAY_DOCKER_REPO_USERNAME }} | ||
| password: ${{ secrets.QUAY_DOCKER_REPO_PASSWORD }} | ||
| - uses: mr-smithers-excellent/docker-build-push@v5 | ||
| name: build-push-docker-image |
Contributor
There was a problem hiding this comment.
Suggested change
| name: build-push-docker-image | |
| name: build-push-docker-image-release |
A tad more telling.
Contributor
Author
There was a problem hiding this comment.
Not sure, what the consequences of this would be, I took Helges changes... so the docker stuff is mostly his stuff :)
Contributor
There was a problem hiding this comment.
I compared this to the workflow in xcube. There, a differentiation was made between latest and release, which I found more telling.
| def get_metadata_from_descriptor(descriptor: xcube_store.DataDescriptor) -> Dict: | ||
| metadata = dict(data_id=descriptor.data_id, | ||
| type_specifier=str(descriptor.type_specifier)) | ||
| type_specifier=str(descriptor.data_type)) |
Contributor
There was a problem hiding this comment.
It would be best if we could get rid of the term "type_specifier" completely. This would require a change in cate-app, though, too.
Co-authored-by: Tonio Fincke <[email protected]>
Co-authored-by: Tonio Fincke <[email protected]>
Co-authored-by: Tonio Fincke <[email protected]>
…cja_xxx_xcube_0.9.1
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When accepting this PR, cate will