Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@mdzik
Copy link
Member

@mdzik mdzik commented Oct 27, 2016

Refactorized d2q9s models: d2q9, d2q9_kuper, d2q9_pf d2q9_csf
Upgraded python integration and unit tests

@llaniewski
Copy link
Member

So this makes the python integration work?

@llaniewski llaniewski added this to the Python Integration milestone Oct 28, 2016
@mdzik
Copy link
Member Author

mdzik commented Oct 28, 2016

Hope so :)
All futures are tested, and I use it for month without errors

2016-10-28 10:49 GMT+02:00 Łukasz Łaniewski-Wołłk [email protected]
:

So this makes the python integration work?


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#108 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/ADYOx8u_FRw6k-MspcfhJhWnAdf6Xb6Yks5q4bcJgaJpZM4Kijan
.

@llaniewski
Copy link
Member

Oi, mate! You broke d2q9.

I cannot allow it! Even example/karman.xml doesn't work! It's over complicated - d2q9 should be the simple one!

@mdzik
Copy link
Member Author

mdzik commented Oct 29, 2016

It probably doesn't work because of the name changes. Will check. (And
karman is not the unit test :p)
Maybe d2q9_simple? We need place to test/add new futures like python, bc
etc/

2016-10-28 16:15 GMT+02:00 Łukasz Łaniewski-Wołłk [email protected]
:

Oi, mate! You broke d2q9.

I cannot allow it! Even example/karman.xml doesn't work! It's over
complicated - d2q9 should be the simple one!


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#108 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/ADYOx7lUw_L-syNM8Yi2HfBUaf0NVD03ks5q4gN0gaJpZM4Kijan
.

@llaniewski
Copy link
Member

@mdzik lot of things happening here. Ready to go?

@mdzik
Copy link
Member Author

mdzik commented Dec 3, 2016

So:

  • it should provide stable python integration
  • I will provide simplified d2q9 soon

I think this should be merged, it's as stable as I could be without wider beta testing ;) And i will wait for feature requests/bugfixes

Sorry for delay - project meeting :/

@llaniewski
Copy link
Member

Can you merge (or rebase), with:
llaniewski@c47eade

So we will have a common trunk.

Then there will be less fuzz downstream.

@mdzik
Copy link
Member Author

mdzik commented Dec 5, 2016 via email

@llaniewski
Copy link
Member

Ok, I did the merge myself. Otherwise we would have a mess.

I will merge this if you do not have nothing more to do here. I will address the d2q9 simpleness later :D

@mdzik
Copy link
Member Author

mdzik commented Dec 5, 2016 via email

@llaniewski llaniewski changed the base branch from develop to v6.1_candidate December 5, 2016 17:42
@llaniewski
Copy link
Member

Changed base to V6.1 RC. Merging.

@llaniewski llaniewski merged commit c7b1361 into CFD-GO:v6.1_candidate Dec 5, 2016
@mdzik mdzik deleted the clean_d2q9s branch December 20, 2016 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants