-
Notifications
You must be signed in to change notification settings - Fork 78
Clean d2q9s #108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clean d2q9s #108
Conversation
Conflicts fixed : src/d2q9_new/Dynamics.c.Rt src/lib/boundary.R
|
So this makes the python integration work? |
|
Hope so :) 2016-10-28 10:49 GMT+02:00 Łukasz Łaniewski-Wołłk [email protected]
|
|
Oi, mate! You broke d2q9. I cannot allow it! Even example/karman.xml doesn't work! It's over complicated - d2q9 should be the simple one! |
|
It probably doesn't work because of the name changes. Will check. (And 2016-10-28 16:15 GMT+02:00 Łukasz Łaniewski-Wołłk [email protected]
|
|
@mdzik lot of things happening here. Ready to go? |
|
So:
I think this should be merged, it's as stable as I could be without wider beta testing ;) And i will wait for feature requests/bugfixes Sorry for delay - project meeting :/ |
|
Can you merge (or rebase), with: So we will have a common trunk. Then there will be less fuzz downstream. |
|
done: #110
2016-12-04 20:39 GMT+01:00 Łukasz Łaniewski-Wołłk <[email protected]>
:
… Can you merge (or rebase), with:
***@***.***
<llaniewski@c47eade>
So we will have a common trunk.
Then there will be less fuzz downstream.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#108 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/ADYOx7tvX0kgVsb2pi1R9tUxySHQf2p5ks5rExbggaJpZM4Kijan>
.
|
|
Ok, I did the merge myself. Otherwise we would have a mess. I will merge this if you do not have nothing more to do here. I will address the d2q9 simpleness later :D |
|
CSF is in a lot of senses a work in progress, but I would say go and deal
with bugfixes later ;)
Python is definitely RC 1
2016-12-05 18:08 GMT+01:00 Łukasz Łaniewski-Wołłk <[email protected]>
:
… Ok, I did the merge myself. Otherwise we would have a mess.
I will merge this if you do not have nothing more to do here. I will
address the d2q9 simpleness later :D
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#108 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/ADYOxx2hbECq350AyFYA9oI5ArhDSBLsks5rFEUBgaJpZM4Kijan>
.
|
|
Changed base to V6.1 RC. Merging. |
Refactorized d2q9s models: d2q9, d2q9_kuper, d2q9_pf d2q9_csf
Upgraded python integration and unit tests